Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

AYON Switch tool: Keep version after switch#6104

Merged
iLLiCiTiT merged 4 commits intodevelopfrom
enhancement/keep-version-after-switch-ayon
Feb 5, 2024
Merged

AYON Switch tool: Keep version after switch#6104
iLLiCiTiT merged 4 commits intodevelopfrom
enhancement/keep-version-after-switch-ayon

Conversation

@iLLiCiTiT
Copy link
Copy Markdown
Member

@iLLiCiTiT iLLiCiTiT commented Jan 4, 2024

Changelog Description

Keep version if only representation did change. The AYON variant of #4629

Additional info

Modified a little OpenPype's version doc resolution which did not count with missing hero version and expected that container version has "name" if representation is not filled.

Testing notes:

  1. Load a subset with several representation(any host)
  2. Set version that is not the last existing version.
  3. Switch the subset representation using the scene inventory.
  4. Version should not change to the latest.

@ynbot ynbot added type: enhancement Enhancements to existing functionality size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Jan 4, 2024
@iLLiCiTiT iLLiCiTiT requested review from BigRoy and antirotor January 4, 2024 15:38
@iLLiCiTiT iLLiCiTiT requested review from Minkiu and kalisp January 9, 2024 10:17
@kalisp
Copy link
Copy Markdown
Member

kalisp commented Jan 26, 2024

It fails (in Fusion) when changing repre:
image

@moonyuet
Copy link
Copy Markdown
Member

moonyuet commented Jan 29, 2024

It is not working from my side neither with similar error mentioned above.

Traceback (most recent call last):
  File "D:\kayla\OpenPype\openpype\tools\ayon_sceneinventory\switch_dialog\dialog.py", line 1173, in _on_accept
    self._trigger_switch()
  File "D:\kayla\OpenPype\openpype\tools\ayon_sceneinventory\switch_dialog\dialog.py", line 1237, in _trigger_switch
    self._switch_container(
  File "D:\kayla\OpenPype\openpype\tools\ayon_sceneinventory\switch_dialog\dialog.py", line 1328, in _switch_container
    repre_doc = repres_by_name[selected_representation]
KeyError: 'max'

@kalisp kalisp assigned iLLiCiTiT and unassigned antirotor Jan 29, 2024
@iLLiCiTiT
Copy link
Copy Markdown
Member Author

iLLiCiTiT commented Feb 5, 2024

It fails (in Fusion) when changing repre:

Should be fixed.

kalisp
kalisp approved these changes Feb 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works (tested in Fusion).

@iLLiCiTiT iLLiCiTiT merged commit fc844f6 into develop Feb 5, 2024
@iLLiCiTiT iLLiCiTiT deleted the enhancement/keep-version-after-switch-ayon branch February 5, 2024 10:55
@ynbot ynbot added this to the next-patch milestone Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BigRoy BigRoy Awaiting requested review from BigRoy

@antirotor antirotor Awaiting requested review from antirotor

@Minkiu Minkiu Awaiting requested review from Minkiu

1 more reviewer

@kalisp kalisp kalisp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iLLiCiTiT iLLiCiTiT

Labels

size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON type: enhancement Enhancements to existing functionality

Projects

PR reviewing
Archived in project

Milestone

3.18.7

Development

Successfully merging this pull request may close these issues.

5 participants

@iLLiCiTiT @kalisp @moonyuet @antirotor @ynbot