This repository was archived by the owner on Sep 20, 2024. It is now read-only.
Conversation
Contributor
|
Task linked: OP-6655 Maya: redshift proxy viewport shader |
BigRoy
reviewed
Jan 4, 2024
BigRoy
reviewed
Jan 4, 2024
BigRoy
approved these changes
Jan 8, 2024
Collaborator
BigRoy
left a comment
There was a problem hiding this comment.
This makes sense, by default a mesh created with cmds.createNode("mesh") does not have a shader assigned. With this added logic it will now get the lambert1 (or standardSurface1) assigned depending on which is the configured initial shading group.
Didn't test, but looks good to me.
antirotor
approved these changes
Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
When the published redshift proxy is being loaded, the shader of the proxy is missing. This is different from the manual load through creating redshift proxy for files. This PR is to assign the default lambert to the redshift proxy, which replicates the same approach when the user manually loads the proxy with filepath.
Additional info
If there is a way of which we should get attributes of proxy materials in redshift proxy mesh, some conditions can be set up for assigning the shader if it exists in the scene.
Testing notes: