Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Ftrack: DJV action fixes#6098

Merged
iLLiCiTiT merged 4 commits intodevelopfrom
bugfix/OP-7516_DJV-action-in-ftrack
Jan 2, 2024
Merged

Ftrack: DJV action fixes#6098
iLLiCiTiT merged 4 commits intodevelopfrom
bugfix/OP-7516_DJV-action-in-ftrack

Conversation

@iLLiCiTiT
Copy link
Copy Markdown
Member

@iLLiCiTiT iLLiCiTiT commented Jan 2, 2024

Changelog Description

Fix bugs in DJV ftrack action.

Additional info

Fixed misspelled variable name, convert executable to string, and access event values from correct variable. Changed formatting to use double quotes.

Testing notes:

  1. Launch OpenPype with enabled ftrack.
  2. Make sure you have djv in applications with valid path.
  3. Show actions for asset version in ftrack, published from OpenPype.
  4. Choose DJV action.
  5. It should start DJV.

@ynbot
Copy link
Copy Markdown
Contributor

ynbot commented Jan 2, 2024

Task linked: OP-7516 DJV action in ftrack

@iLLiCiTiT iLLiCiTiT requested a review from m-u-r-p-h-y January 2, 2024 13:35
hound[bot]
hound bot reviewed Jan 2, 2024
View reviewed changes
@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files module: Ftrack labels Jan 2, 2024
@iLLiCiTiT iLLiCiTiT added target: OpenPype sponsored Client endorsed or requested labels Jan 2, 2024
m-u-r-p-h-y
m-u-r-p-h-y approved these changes Jan 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

image

@iLLiCiTiT iLLiCiTiT merged commit 7200cf6 into develop Jan 2, 2024
@iLLiCiTiT iLLiCiTiT deleted the bugfix/OP-7516_DJV-action-in-ftrack branch January 2, 2024 14:46
@ynbot ynbot added this to the next-patch milestone Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@hound hound[bot] hound[bot] left review comments

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@m-u-r-p-h-y m-u-r-p-h-y

Labels

module: Ftrack size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested target: OpenPype type: bug Something isn't working

Projects

PR reviewing
Archived in project

Milestone

3.18.2

Development

Successfully merging this pull request may close these issues.

3 participants

@iLLiCiTiT @ynbot @m-u-r-p-h-y