Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: Extract Review Intermediate disabled when both Extract Review Mov and Extract Review Intermediate disabled in setting#6089

Merged
moonyuet merged 2 commits intodevelopfrom
enhancement/enable_options_extract_review_intermediate
Jan 2, 2024
Merged

Nuke: Extract Review Intermediate disabled when both Extract Review Mov and Extract Review Intermediate disabled in setting#6089
moonyuet merged 2 commits intodevelopfrom
enhancement/enable_options_extract_review_intermediate

Conversation

@moonyuet
Copy link
Copy Markdown
Member

@moonyuet moonyuet commented Dec 23, 2023

Changelog Description

Report in Discord https://discord.com/channels/517362899170230292/563751989075378201/1187874498234556477

Additional info

n/a

Testing notes:

  1. Go to Settings, disabled both Extract Review Mov and Extract Review Intermediate in Nuke Publish
  2. Launch Nuke
  3. Create Render Instance
  4. Publish
  5. It won't show up the extract review intermediate
  6. If you turn on either Extract Review Mov or Extract Review Intermediate, the extractor show up and the related setting applied to the extraction
  7. If you turn on both settings, it will apply the setting from Extract Review Mov

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality host: Nuke labels Dec 23, 2023
@fabiaserra
Copy link
Copy Markdown
Contributor

fabiaserra commented Dec 23, 2023

Thank you!

jakubjezek001
jakubjezek001 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moonyuet moonyuet merged commit 1438c99 into develop Jan 2, 2024
@moonyuet moonyuet deleted the enhancement/enable_options_extract_review_intermediate branch January 2, 2024 13:50
@ynbot ynbot added this to the next-patch milestone Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BigRoy BigRoy Awaiting requested review from BigRoy

1 more reviewer

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

host: Nuke size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON target: OpenPype type: enhancement Enhancements to existing functionality

Projects

PR reviewing
Archived in project

Milestone

3.18.2

Development

Successfully merging this pull request may close these issues.

4 participants

@moonyuet @fabiaserra @jakubjezek001 @ynbot