This repository was archived by the owner on Sep 20, 2024. It is now read-only.
Python console widget: Save registry fix#6076
Merged
Conversation
kalisp
approved these changes
Dec 20, 2023
Member
kalisp
left a comment
There was a problem hiding this comment.
Looks good. Tried to open/close console couple of time.
(Btw. it is saving only size to registry, not position, correct?)
Member
Author
Position is actually potential danger. Changes of resolution, scaling etc. can cause that window would appear out of desktop positions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Do not save registry until there is something to save.
Additional info
The addon logic tries to store last save registry even if console is not showed up at all, which may lead to confusing scenarios when
Noneis stored as ideal width and height etc.