This repository was archived by the owner on Sep 20, 2024. It is now read-only.
Conversation
Thumbnail representation is set to 'delete', eg wont be integrated, another source of thumbnail must be used. This will effectively limit option of NOT pushing thumbnail to Ayon, which use case I am actuall not seeing.
Contributor
64qam
approved these changes
Dec 18, 2023
iLLiCiTiT
reviewed
Dec 18, 2023
iLLiCiTiT
reviewed
Dec 18, 2023
iLLiCiTiT
reviewed
Dec 18, 2023
iLLiCiTiT
reviewed
Dec 18, 2023
iLLiCiTiT
reviewed
Dec 18, 2023
It works even for OP. Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Thumbnails from any products (either
reviewnor separate layer instances) weren't stored in Ayon.This resulted in not showing them in Loader and Server UI. After this PR thumbnails should be shown in the Loader and on the Server (
http://YOUR_AYON_HOSTNAME:5000/projects/YOUR_PROJECT/browser).Additional info
Tis PR explicitly sets path to thumbnail on the instance (as there might be only one thumbnail per instance, imho) bypassing issue that representation with 'name' == 'thumbnail' is by default set to not be integrated.
Testing notes:
reviewinstanceimageinstances which haveReviewtoggle set to True