Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Blender: Workfile instance update fix#6048

Merged
iLLiCiTiT merged 2 commits intodevelopfrom
bugfix/blender-workfile-create-fix
Jan 11, 2024
Merged

Blender: Workfile instance update fix#6048
iLLiCiTiT merged 2 commits intodevelopfrom
bugfix/blender-workfile-create-fix

Conversation

@iLLiCiTiT
Copy link
Copy Markdown
Member

@iLLiCiTiT iLLiCiTiT commented Dec 13, 2023

Changelog Description

Make sure workfile instance has always available 'instance_node' in transient data.

Additional info

The instance node was available only if something had changed or the instance was created.

Testing notes:

  1. Launch blender
  2. Open publisher tool
  3. Save and Reset tool
  4. There should not be any issue saving it

@ynbot ynbot added host: Blender size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working labels Dec 13, 2023
@BigRoy BigRoy mentioned this pull request Dec 13, 2023
Closed
2 tasks
@moonyuet
Copy link
Copy Markdown
Member

moonyuet commented Jan 3, 2024

I have tested with Blender.
Save and reset works as expected. But I do have a question: Is it normal for the optional extractor always turned off after save while I turned on it (before save)?
You can find the video below as reference.
https://github.com/ynput/OpenPype/assets/64118225/2ba0e727-aff6-4b2f-a46c-c3e1d292afb0

@BigRoy
Copy link
Copy Markdown
Collaborator

BigRoy commented Jan 3, 2024 •
edited
Loading

I have tested with Blender. Save and reset works as expected. But I do have a question: Is it normal for the optional extractor always turned off after save while I turned on it (before save)? You can find the video below as reference. https://github.com/ynput/OpenPype/assets/64118225/2ba0e727-aff6-4b2f-a46c-c3e1d292afb0

No, that would be a bug. The value should persist.

However since that toggle is not on the workfile instance I believe it has nothing to do with this PR and likely was a bug prior to it?

@iLLiCiTiT iLLiCiTiT merged commit 629b49c into develop Jan 11, 2024
@iLLiCiTiT iLLiCiTiT deleted the bugfix/blender-workfile-create-fix branch January 11, 2024 15:15
@ynbot ynbot added this to the next-patch milestone Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@BigRoy BigRoy BigRoy left review comments

@simonebarbieri simonebarbieri simonebarbieri approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@simonebarbieri simonebarbieri

Labels

community contribution host: Blender size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working

Projects

PR reviewing
Archived in project

Milestone

3.18.3

Development

Successfully merging this pull request may close these issues.

5 participants

@iLLiCiTiT @moonyuet @BigRoy @simonebarbieri @ynbot