Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Traypublisher: editorial avoid audio tracks processing#6038

Merged
iLLiCiTiT merged 7 commits intodevelopfrom
bugfix/traypublish-editorial-avoid-audio-track
Feb 7, 2024
Merged

Traypublisher: editorial avoid audio tracks processing#6038
iLLiCiTiT merged 7 commits intodevelopfrom
bugfix/traypublish-editorial-avoid-audio-track

Conversation

@jakubjezek001
Copy link
Copy Markdown
Member

@jakubjezek001 jakubjezek001 commented Dec 11, 2023 •
edited
Loading

Changelog Description

Avoiding audio tracks from EDL editorial publishing.

Additional info

  • Refactored the code to filter tracks based on their kind being "Video"
  • Added a comment to clarify the purpose of media_data variable
  • Added a comment to explain setting track name
  • Removed an unnecessary blank line

TODO:

  • Fix: missing otioReference on video clips once audio tracks are avoided

Testing notes:

  1. Test it on Simple Editorial workflow in Traypublisher
  2. make sure that each clip is having AA/V mark in tracks column.

@jakubjezek001
Refactor create_editorial.py for better track handling
6f21911 
- Refactored the code to filter tracks based on their kind being "Video"
- Added a comment to clarify the purpose of media_data variable
- Added a comment to explain setting track name
- Removed an unnecessary blank line
@jakubjezek001
improving plugin label so it is easier to read
fc179be
@jakubjezek001 jakubjezek001 requested a review from 64qam December 11, 2023 09:47
@ynbot ynbot added type: bug Something isn't working host: TrayPublisher size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Dec 11, 2023
@iLLiCiTiT iLLiCiTiT changed the title Traypublisher: editoiral avoid audio tracks processing Traypublisher: editorial avoid audio tracks processing Dec 11, 2023
iLLiCiTiT
iLLiCiTiT approved these changes Dec 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@iLLiCiTiT iLLiCiTiT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look reasonable.

@jakubjezek001 jakubjezek001 marked this pull request as draft December 20, 2023 15:58
iLLiCiTiT
iLLiCiTiT approved these changes Dec 21, 2023 •
edited
Loading
View reviewed changes
@jakubjezek001
Merge branch 'develop' into bugfix/traypublish-editorial-avoid-audio-…
acc2f9f 
…track
@jakubjezek001
Merge branch 'develop' into bugfix/traypublish-editorial-avoid-audio-…
3acd53e 
…track
@jakubjezek001
Refactor code for creating and publishing editorial clips
0bbe25f 
- renaming variable to specify correctly value type
- Added a condition in `collect_shot_instances.py` to check if the parent kind is "Video" before collecting shot instances.
@jakubjezek001 jakubjezek001 marked this pull request as ready for review January 29, 2024 16:01
@jakubjezek001
Copy link
Copy Markdown
Member Author

jakubjezek001 commented Jan 29, 2024

Task linked: OP-7579 Editorial: fix collect editorial resources

@iLLiCiTiT iLLiCiTiT merged commit 0c37c0e into develop Feb 7, 2024
@iLLiCiTiT iLLiCiTiT deleted the bugfix/traypublish-editorial-avoid-audio-track branch February 7, 2024 10:20
@ynbot ynbot added this to the next-patch milestone Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@64qam 64qam Awaiting requested review from 64qam

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

1 more reviewer

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antirotor antirotor

Labels

host: TrayPublisher size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON target: OpenPype type: bug Something isn't working

Projects

PR reviewing
Archived in project

Milestone

3.18.7

Development

Successfully merging this pull request may close these issues.

5 participants

@jakubjezek001 @iLLiCiTiT @mkolar @antirotor @ynbot