Should this attribute definition instead maybe be on the extractor instead of the creator since it's so related to this extractor.

Should this attribute definition instead maybe be on the extractor instead of the creator since it's so related to this extractor.
@BigRoy do you mean putting it as a class attribute? Like here:

OpenPype/openpype/hosts/maya/plugins/publish/extract_maya_scene_raw.py

Lines 17 to 24 in 187b408

	label = "Maya Scene (Raw)"
	hosts = ["maya"]
	families = ["mayaAscii",
	"mayaScene",
	"setdress",
	"layout",
	"camerarig"]
	scene_type = "ma"

No, as get_attribute_defs like here.

Values are then retrieved like so.

Note to also inherit from OpenPypePyblishPluginMixin or the OptionalPyblishPluginMixin.

No, as get_attribute_defs like here.

Values are then retrieved like so.

Note to also inherit from OpenPypePyblishPluginMixin or the OptionalPyblishPluginMixin.

I agree and I have a question on whether we need OP/AYON setting which pre-sets the particular option as we are adding the setting in the creator?
If yes, it also probably needs apply_settings function to sync the OP/AYON setting to align with the creator setting.

def apply_settings(self, project_settings):
        # your code....

If no, it is just perhaps adding the setting into the extractor and add get_attribute_defs function. And call the value back with some_values = self.get_attr_values_from_data(instance.data) (like BigRoy said).