Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Bug fix the file from texture node not being collected correctly in Yeti Rig#5990

Merged
moonyuet merged 12 commits intodevelopfrom
bugfix/OP-7463_Maya-Yeti-publish-textures
Dec 22, 2023
Merged

Maya: Bug fix the file from texture node not being collected correctly in Yeti Rig#5990
moonyuet merged 12 commits intodevelopfrom
bugfix/OP-7463_Maya-Yeti-publish-textures

Conversation

@moonyuet
Copy link
Copy Markdown
Member

@moonyuet moonyuet commented Dec 4, 2023 •
edited
Loading

Changelog Description

Fix the bug of collect Yeti Rig not being able to get the file parameter(s) from the texture node(s), resulting to the failure of publishing the textures to the resource directory.

Additional info

Make sure you have Yeti installed in Maya (with the license, too)

Testing notes:

  1. Launch Maya via launcher
  2. Create Yeti Rig Instance with your pgYetiMaya node.
  3. Publish
  4. It is supposed that the resources folder showed in your publish folder and the image search path would show the resource directory from the published folder.
    image

@ynbot
Copy link
Copy Markdown
Contributor

ynbot commented Dec 4, 2023

Task linked: OP-7463 Maya: Yeti publish textures

@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Maya labels Dec 4, 2023
@moonyuet moonyuet marked this pull request as ready for review December 5, 2023 05:34
LiborBatek
LiborBatek suggested changes Dec 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did tests in legacy OP for now but no luck...the publish being produced but without any trace of folder resources with any groom image maps...

image

And the texture path on the left Attribute pane:
image

@moonyuet
Copy link
Copy Markdown
Member Author

moonyuet commented Dec 20, 2023 •
edited
Loading

@LiborBatek
Which version of maya are you using?
I am using same Yeti version with you, but I can extract the Yeti rig with resources folder in my side.

yeti_demonstration.mp4

BigRoy
BigRoy reviewed Dec 20, 2023
View reviewed changes
@LiborBatek
Copy link
Copy Markdown
Member

LiborBatek commented Dec 20, 2023

@LiborBatek Which version of maya are you using? I am using same Yeti version with you, but I can extract the Yeti rig with resources folder in my side.

yeti_demonstration.mp4

My being maya 2023 ...but as seen on your scrn capture, u have prefilled the path to your source folder with image map...this I didnt done....I have kept it blank (I was thinking that it get filled by the new asset/publish/ver/sources/.. just as soon as loaded into empty scene via loader overriding those present paths in the actual Yeti graph as sort of override...

So it makes sense to keep it empty (without user needing to care about it).

The Yeti addon has it just for cases when textures couldnt be find straight from the graph image nodes...which is the case with our Published yeti assets...

@LiborBatek
Copy link
Copy Markdown
Member

LiborBatek commented Dec 20, 2023

I was refering to this one> Image Search Path

image

@LiborBatek LiborBatek self-requested a review December 20, 2023 11:02
LiborBatek
LiborBatek approved these changes Dec 20, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When user prefills the texture path in Search Image Path slot it all works and publishes well with all resource texture maps!

Working fine when loaded into empty workfile as yetiRig asset and with correct path set to the publish folder version.

Approve!

image

@BigRoy
Copy link
Copy Markdown
Collaborator

BigRoy commented Dec 20, 2023

So it makes sense to keep it empty (without user needing to care about it).

The Yeti addon has it just for cases when textures couldnt be find straight from the graph image nodes...which is the case with our Published yeti assets...

This should still be fixed right - so that it behaves like you describe? Making it work even if in the work scene the user had image search path empty?

BigRoy
BigRoy reviewed Dec 20, 2023
View reviewed changes
BigRoy
BigRoy reviewed Dec 20, 2023
View reviewed changes
LiborBatek
LiborBatek approved these changes Dec 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works even when Image Search Path being left blank in the source workfile / yeti setup.

Also been successfully tested in both Legacy mode and AYON mode ...all working fine and without any issues!

antirotor
antirotor approved these changes Dec 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested it, but code looks good

@moonyuet moonyuet merged commit a41b0ae into develop Dec 22, 2023
@moonyuet moonyuet deleted the bugfix/OP-7463_Maya-Yeti-publish-textures branch December 22, 2023 10:36
@ynbot ynbot added this to the next-patch milestone Dec 22, 2023
@azhagurajpandians
Copy link
Copy Markdown

azhagurajpandians commented Jun 27, 2024

I'm experiencing issues with UDIM Textures. It's not recognizing or reading the textures with UDIM tags. Multiple texture tiles are not being found. I've checked the path in the Image Search Path slot as well and tested in both legacy OP and Ayon, but I'm encountering the same issue.
maya_dU64gqix1R
maya_EBs2neCVYJ

@moonyuet moonyuet mentioned this pull request Jun 27, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@BigRoy BigRoy BigRoy left review comments

@antirotor antirotor antirotor approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LiborBatek LiborBatek

Labels

host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON type: bug Something isn't working

Projects

PR reviewing
Archived in project

Milestone

3.18.2

Development

Successfully merging this pull request may close these issues.

7 participants

@moonyuet @ynbot @LiborBatek @BigRoy @azhagurajpandians @antirotor @mkolar