This repository was archived by the owner on Sep 20, 2024. It is now read-only.
Testing: Release Maya/Deadline job from pending when testing.#5988
Merged
kalisp merged 5 commits intoynput:developfrom Jan 3, 2024
Merged
Conversation
Contributor
Author
|
Split from #5644 |
This test was created as simple model and workfile publish, without Deadline rendering. Cleaned up render elements.
kalisp
suggested changes
Dec 7, 2023
Member
kalisp
left a comment
There was a problem hiding this comment.
Are the changes in submit* absolute necessary? They are ugly af.
I don't see to much performance gains vs polluting code with this check. (I cry anytime I need to put one of these somewhere.)
Contributor
Author
|
@kalisp not sure what removing the render instance, has to do with this PR?
I would be up for leaving the changes in submit publish plugin, as it could introduce issues down the line if spawning multiple workers on a machine. |
…g_deadline_maya_pending # Conflicts: # tests/integration/hosts/maya/test_publish_in_maya/expected/test_project/test_asset/work/test_task/test_project_test_asset_test_task_v001.ma # tests/integration/hosts/maya/test_publish_in_maya/expected/test_project/test_asset/work/test_task/test_project_test_asset_test_task_v002.ma # tests/integration/hosts/maya/test_publish_in_maya/input/workfile/test_project_test_asset_test_task_v001.ma
kalisp
approved these changes
Jan 3, 2024
Member
|
It seems to work and doesn't break anything else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
When testing we wont put the Deadline jobs into pending with dependencies, so the worker can start as soon as possible.
Testing notes:
Verify the jobs on Deadline are not put into pending initially.