Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Houdini: Add loader for redshift proxy family#5948

Merged
antirotor merged 5 commits intodevelopfrom
enhancement/OP-7352_Houdini-Loader-for-rs-cache
Jan 10, 2024
Merged

Houdini: Add loader for redshift proxy family#5948
antirotor merged 5 commits intodevelopfrom
enhancement/OP-7352_Houdini-Loader-for-rs-cache

Conversation

@moonyuet
Copy link
Copy Markdown
Member

@moonyuet moonyuet commented Nov 23, 2023

Changelog Description

Loader for Redshift Proxy in Houdini (Thanks for @BigRoy contribution)

Additional info

n/a

Testing notes:

  1. Launch Houdini
  2. Create Redshift Proxy Instance
  3. Publish
  4. Load the redshiftproxy instance through loader
  5. It should be loaded as expected.

@ynbot
Copy link
Copy Markdown
Contributor

ynbot commented Nov 23, 2023

Task linked: OP-7352 Houdini: Loader for rs cache

@ynbot ynbot added type: enhancement Enhancements to existing functionality size/S Denotes a PR changes 100-499 lines, ignoring general files host: Houdini labels Nov 23, 2023
@MustafaJafar
Copy link
Copy Markdown
Member

MustafaJafar commented Nov 23, 2023

I have exhausted my Free RS License, Can't test it!
I'll try as soon as I find a solution.

@moonyuet moonyuet requested a review from antirotor November 23, 2023 11:51
BigRoy
BigRoy reviewed Nov 24, 2023
View reviewed changes
@moonyuet moonyuet requested a review from BigRoy November 24, 2023 09:15
BigRoy
BigRoy reviewed Nov 24, 2023
View reviewed changes
@moonyuet moonyuet requested a review from BigRoy November 24, 2023 10:35
BigRoy
BigRoy reviewed Nov 24, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it - but looks fine for me.

antirotor
antirotor approved these changes Jan 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it works! Thanks. We'll need probably some options in the settings later on.

@antirotor antirotor merged commit b3d5223 into develop Jan 10, 2024
@ynbot ynbot added this to the next-patch milestone Jan 10, 2024
@antirotor antirotor deleted the enhancement/OP-7352_Houdini-Loader-for-rs-cache branch January 10, 2024 11:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@MustafaJafar MustafaJafar Awaiting requested review from MustafaJafar

2 more reviewers

@BigRoy BigRoy BigRoy left review comments

@antirotor antirotor antirotor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antirotor antirotor

Labels

host: Houdini size/S Denotes a PR changes 100-499 lines, ignoring general files target: AYON type: enhancement Enhancements to existing functionality

Projects

PR reviewing
Archived in project

Milestone

3.18.3

Development

Successfully merging this pull request may close these issues.

6 participants

@moonyuet @ynbot @MustafaJafar @BigRoy @antirotor @mkolar