Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Maya: bug fix the playblast without textures#5942

Merged
moonyuet merged 58 commits intodevelopfrom
bugfix/OP-7281_Maya-Review---playblast-renders-without-textures
Jan 3, 2024
Merged

Maya: bug fix the playblast without textures#5942
moonyuet merged 58 commits intodevelopfrom
bugfix/OP-7281_Maya-Review---playblast-renders-without-textures

Conversation

@moonyuet
Copy link
Copy Markdown
Member

@moonyuet moonyuet commented Nov 22, 2023

Changelog Description

Bug fix the texture not being displayed when users enable texture placement in the OP/AYON setting

Additional info

It causes additional time for playblasting if users have tons of UDIMs texture.

Testing notes:

  1. Go to project_settings/maya/publish/ExtractPlayblast/ to add profiles
  2. Go to project_settings/maya/publish/ExtractPlayblast/profiles/0/capture_preset/Viewport Options/loadTextures
  3. Enable this also
  4. Launch Maya
  5. Create Review while creating some other instances from other families
  6. Publish.

@ynbot
Copy link
Copy Markdown
Contributor

ynbot commented Nov 22, 2023

@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Maya labels Nov 22, 2023
@moonyuet moonyuet marked this pull request as ready for review November 22, 2023 12:13
@moonyuet moonyuet requested a review from BigRoy November 23, 2023 09:31
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OP does create Review with textures being loaded and also forcing regenerate all UV tiles previews.

image

Small note:

during publishing of the review there some warnings of failures, not sure if relevant but at least something to consider, even tho this PR being functional...
image

@moonyuet moonyuet requested a review from BigRoy November 24, 2023 08:59
Copy link
Copy Markdown
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change capture.py dependency, pop the reloadTextures key instead.

Other than that the code looks good.

@moonyuet moonyuet requested a review from BigRoy November 27, 2023 10:09
@moonyuet moonyuet requested a review from BigRoy December 21, 2023 10:33
@moonyuet moonyuet requested a review from BigRoy December 21, 2023 16:35
Copy link
Copy Markdown
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not do a test run, sorry! But the code changes do look like decent cleanup and refactoring. Good stuff! Please do some thorough testing of reviews and thumbnails, whether the presets settings still propagate as expected, whether resolutions are still ok, etc.

Once that's done, then 🚀

Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another test go in maya 2023 and maya 2024 but without any success

still
image

Also enclosing full JSON report when publishing...

publish-report-240102-14-17.json.txt

@moonyuet
Copy link
Copy Markdown
Member Author

moonyuet commented Jan 2, 2024

@LiborBatek I have updated the testing notes and codes regarding to your suggestion in discord. Can you please test it? Thanks!

@moonyuet moonyuet requested a review from LiborBatek January 2, 2024 14:55
Copy link
Copy Markdown
Contributor

@Minkiu Minkiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it, but code looks good.

Copy link
Copy Markdown
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it in Maya 2024 and it works, code looks reasonable too, so 👍🏻

@moonyuet
Copy link
Copy Markdown
Member Author

moonyuet commented Jan 3, 2024

@LiborBatek can you possibly test again? This ticket needs your approval so that it can be merged, Thanks!

Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems working fine! Now
image

@moonyuet moonyuet merged commit 5e48d24 into develop Jan 3, 2024
@moonyuet moonyuet deleted the bugfix/OP-7281_Maya-Review---playblast-renders-without-textures branch January 3, 2024 16:03
@ynbot ynbot added this to the next-patch milestone Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

host: Maya size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested target: AYON type: bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

9 participants