Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Blender: Refactor to new publisher#5910

Merged
simonebarbieri merged 93 commits intoynput:developfrom
BigRoy:enhancement/blender_new_publisher
Nov 15, 2023
Merged

Blender: Refactor to new publisher#5910
simonebarbieri merged 93 commits intoynput:developfrom
BigRoy:enhancement/blender_new_publisher

Conversation

@BigRoy
Copy link
Copy Markdown
Collaborator

@BigRoy BigRoy commented Nov 14, 2023 •
edited
Loading

Changelog Description

Refactor Blender integration to use the new publisher

Additional info

Thanks to tremendous effort by @Sharkitty there's a big start, you can actually make valid publishes already!

There are todos however:

  • Convert legacy instances
  • Fix #TODO statements
  • Refactor Load Blend to use new style creator creation for rigs
  • Clear up what Create Review "asset_group" pre_create_data should be doing
  • Animation Creator should maybe be a HiddenCreator? Animation instances in Blender seem to be much simpler than in Maya so they are easier to create; also loading rigs doesn't automatically create an animation instance yet it seems. So I believe they should remain visible.

And some additional things to test/validate they work as intended:

  • Persist instance + context data correctly on saves (toggle states in publisher should work on reset and scene re-open)
  • All validators should report PublishValidationErrors
  • All creators/publishers should still work
  • Optional settings should still work

Testing notes:

  1. Launch Blender
  2. Use new publisher
  3. Break it and report issues here!

Tested Publish types:

  • Action - sidenote: There's a known bug from prior to this PR that loading action does not work.
  • Animation
  • BlendScene
  • Camera
  • Layout
  • Model
  • Pointcache
  • Render
  • Review
  • Rig

@Sharkitty
Refactor: Blender new publisher
507adfa
@Sharkitty
draft implementation for blender creator refactor
e06dfbb
@Sharkitty
blender creator cache subsets
3c19869
@Sharkitty
Add identifiers to blender creators. Fix wrong method name
d4c030e
@Sharkitty
fixed wrong variable name
efa294d
@Sharkitty
draft blenderhost class implementation
b681173
@Sharkitty
Fix update_container_data error
3b7ed1d
@Sharkitty
Added properties to blender host
7bdbf02
@Sharkitty
Fixed errors during create
d9960e8
@Sharkitty
Fixes to base creator, creators compatibility
cf66d12
@Sharkitty
blender creator instances added to context
e0e7c96
@Sharkitty
Add dict to imprint, type hints in blenderhost, imprint in create
6eae2c2
@Sharkitty
Set shared data, edit loop in cached_subsets
7617d1e
@Sharkitty
Collect instances functional
aeebd78
@Sharkitty
Set subset in inst data, use update to set it
4d03c1c
@Sharkitty
implement IWorkfileHost for Blender host
8236e46
@Sharkitty
Handling optional plugins
e9d022b
@Sharkitty
Handling instance noce
656a42d
@Sharkitty
Removed useless pprint
5f7847c
@Sharkitty
Enhance instance_node, wip remove_inst, rm extra empty lines
f52c9f0
@Sharkitty
Apply creator change to bl base creator
371d740
@Sharkitty
Fix Cannot pickle object error
e832cf5
@Sharkitty
Fix collectreview
78b3337
@Sharkitty
change creator labels
a12d599
@Sharkitty
wip create blend scene create render
cb4dd25
@Sharkitty
update blender creator
4f658d2
@Sharkitty
Rename BlenderCreator into BaseCreator
59bb86d
@Sharkitty
Add Create workfile plugin
976ff30
@Sharkitty
Add collect workfile to blender host
10aea10
@Sharkitty
collect workfile remove unused import and comment
93101de
@iLLiCiTiT
Copy link
Copy Markdown
Member

iLLiCiTiT commented Nov 14, 2023

Shouldn't the "Subsets" word be replaced in the new GUI by "Products", to match Ayon's Web App ?

Unrelated to this PR (and people working on it).

@BigRoy
Copy link
Copy Markdown
Collaborator Author

BigRoy commented Nov 14, 2023

UIs will now pop up to the front if they are behind another window or were minimized - I kept searching for e.g. the loader or publisher, this resolves it in Blender. Checked with @simonebarbieri and decided to put it in this PR. 🤞

@BigRoy
Copy link
Copy Markdown
Collaborator Author

BigRoy commented Nov 14, 2023

That'd be a quick one if this is ready now! 🌪️ 🔥

@BigRoy BigRoy requested a review from iLLiCiTiT November 14, 2023 16:47
simonebarbieri
simonebarbieri reviewed Nov 14, 2023
View reviewed changes
@simonebarbieri
Copy link
Copy Markdown
Contributor

simonebarbieri commented Nov 14, 2023

UIs will now pop up to the front if they are behind another window or were minimized - I kept searching for e.g. the loader or publisher, this resolves it in Blender.

This works! 🎉

@simonebarbieri
Copy link
Copy Markdown
Contributor

simonebarbieri commented Nov 15, 2023

Animation instances in Blender seem to be much simpler than in Maya so they are easier to create; also loading rigs doesn't automatically create an animation instance yet it seems. So I believe they should remain visible.

Sorry I missed this edit! Animations are created when loading a layout with rigs, not just rigs! This was done because of the original workflow that we had in mind, that was more "Blender -> Unreal". Now it can be used to also export Alembic, which actually work within Blender, (and theoretically blend, but it doesn't work and not because of this PR), so it can be kept visible :)
In general I think the animation family needs a serious rework in the future, when we have time 😅

@BigRoy
Fix extract animation
480c375 
- `asset_group` is a Collection and can't be selected, and thus not exported from so we now take the 'root' node in that collection
@BigRoy
Rename instance node if asset or subset changed to match with new name
dd54866
@BigRoy
Copy link
Copy Markdown
Collaborator Author

BigRoy commented Nov 15, 2023

@LiborBatek @simonebarbieri was there anything else - do we need a final test run before merging?

@LiborBatek
Copy link
Copy Markdown
Member

LiborBatek commented Nov 15, 2023

@LiborBatek @simonebarbieri was there anything else - do we need a final test run before merging?

Lets do last round of tests...will inform what are the findings asap!

simonebarbieri
simonebarbieri approved these changes Nov 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@simonebarbieri simonebarbieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @LiborBatek is still finishing some tests, so let's wait for his review as well, but for I've tested more or less everything and it works great!

Great job @BigRoy and @Sharkitty ! :)

@LiborBatek LiborBatek self-requested a review November 15, 2023 16:50
LiborBatek
LiborBatek approved these changes Nov 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested both in legacy OP and Ayon mode and all good!!

Great job everyone who involved in this PR!!

@simonebarbieri simonebarbieri merged commit a53e949 into ynput:develop Nov 15, 2023
@ynbot ynbot added this to the next-patch milestone Nov 15, 2023
@iLLiCiTiT iLLiCiTiT mentioned this pull request Nov 15, 2023
Merged
18 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

3 more reviewers

@Sharkitty Sharkitty Sharkitty left review comments

@simonebarbieri simonebarbieri simonebarbieri approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community contribution host: Blender module: Deadline AWS Deadline related features size/L Denotes a PR changes 1000-1499 lines, ignoring general files type: enhancement Enhancements to existing functionality type: refactor Structural changes not affecting functionality

Projects

PR reviewing
Archived in project

Milestone

3.17.6

Development

Successfully merging this pull request may close these issues.

7 participants

@BigRoy @LiborBatek @Sharkitty @simonebarbieri @alainxi @iLLiCiTiT @ynbot