Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: Change context label enhancement#5887

Merged
iLLiCiTiT merged 2 commits intodevelopfrom
enhancement/nuke-change-context-label
Nov 16, 2023
Merged

Nuke: Change context label enhancement#5887
iLLiCiTiT merged 2 commits intodevelopfrom
enhancement/nuke-change-context-label

Conversation

@iLLiCiTiT
Copy link
Copy Markdown
Member

Changelog Description

Use QAction to change label of context label in Nuke pipeline menu.

Additional info

This is preparation for #5817 where asset in context will contain slashes, which nuke converts into submenus when addCommand is used. That was modified. Returned object from addCommand should have action() method which returns QAction object on which is possible to call setText to change the label.

Added skip of change label function if in nuke assist.

Testing notes:

Test this PR in oldest possible nuke we should support.

  1. The context label should be set on launcher.
  2. The context label should be changed when context changes via workfiles tool.

@ynbot ynbot added type: enhancement Enhancements to existing functionality host: Nuke size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Nov 8, 2023
Copy link
Copy Markdown
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works and looks the same as before.
Tested in OpenPype and Ayon. But folder path was not reflected in the label since the implementation is not part of this codespace.

@iLLiCiTiT iLLiCiTiT merged commit 19f0a77 into develop Nov 16, 2023
@iLLiCiTiT iLLiCiTiT deleted the enhancement/nuke-change-context-label branch November 16, 2023 16:22
@ynbot ynbot added this to the next-patch milestone Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

host: Nuke size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants