Maya: Remove shelf class and shelf build on maya userSetup.py#5837
Maya: Remove shelf class and shelf build on maya userSetup.py#5837mkolar merged 3 commits intoynput:developfrom
shelf class and shelf build on maya userSetup.py#5837Conversation
moonyuet
left a comment
There was a problem hiding this comment.
Launches Maya successfully without any error and I have done some quick test with the publishing and so far so good. I also take a look at Openpype tool and open dialogs to see if it has registered and all look fine.
Code looks good for me too.
|
Agreed. this has been used on some old productions to build custom shelfs and clearly a legacy bit. We have a small conflict, but happy to merge when that is resolved. |
…hore/maya_shelf_build_cleanup # Conflicts: # openpype/hosts/maya/api/lib.py
|
@mkolar should be resolved now |
tokejepsen
left a comment
There was a problem hiding this comment.
Tested in Maya 2023 successfully. Ready to merge.
|
Yay, time for merging! 🚀 |
|
Shame to not merge this even though technically it should not make it to OP anymore. @bradenjennings could you please port it to ayon-core, so we can merge both at the same time? |
Changelog Description
Remove shelf builder logic. It appeared to be unused and had bugs.
Additional info
Bugs/unused:
self._nulleven though it didn't exist there.buildmethod - it didn't; it ran a preset dict.settings['maya'].get('project_shelf')which is not an existing key in project settings.OPENPYPE_PROJECT_SCRIPTSin the build but it's not set anywhere so will be confusing to anyone if it were to be run even (since it doesn't have settings you can't run it.)execcalls and could be potentially abused by someone savvy with ill intent.addMenuItemdidn't set the icon if it were passed@mkolar Do you know of someone somewhere potentially using this? It seemed originally coded by you but I have a feeling its ancient and now unused code.
Testing notes: