Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Max: Tweaks on Extractions for the exporters#5814

Merged
moonyuet merged 12 commits intodevelopfrom
enhancement/OP-7133_3dsMax--optional-custom-attributes-for-abc-extract
Dec 15, 2023
Merged

Max: Tweaks on Extractions for the exporters#5814
moonyuet merged 12 commits intodevelopfrom
enhancement/OP-7133_3dsMax--optional-custom-attributes-for-abc-extract

Conversation

@moonyuet
Copy link
Copy Markdown
Member

@moonyuet moonyuet commented Oct 24, 2023

Changelog Description

With this PR

  1. Suspend Refresh would be introduced in abc & obj extractors for optimization.
  2. Allow users to choose the custom attributes to be included in abc exports

Additional info

Not included the usd exporters

Testing notes:

  1. Create Model/PointCache/Camera Instance
  2. Publish

@ynbot
Copy link
Copy Markdown
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7133 3dsMax: optional custom attributes for abc extract

5 similar comments
@ynbot
Copy link
Copy Markdown
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7133 3dsMax: optional custom attributes for abc extract

@ynbot
Copy link
Copy Markdown
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7133 3dsMax: optional custom attributes for abc extract

@ynbot
Copy link
Copy Markdown
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7133 3dsMax: optional custom attributes for abc extract

@ynbot
Copy link
Copy Markdown
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7133 3dsMax: optional custom attributes for abc extract

@ynbot
Copy link
Copy Markdown
Contributor

ynbot commented Oct 24, 2023

Task linked: OP-7133 3dsMax: optional custom attributes for abc extract

@ynbot ynbot added type: enhancement Enhancements to existing functionality host: 3dsmax Autodesk 3dsmax size/S Denotes a PR changes 100-499 lines, ignoring general files labels Oct 24, 2023
BigRoy
BigRoy reviewed Oct 24, 2023
View reviewed changes
BigRoy
BigRoy reviewed Oct 24, 2023
View reviewed changes
LiborBatek
LiborBatek reviewed Oct 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested if Custom Attribs got written but all Publish actions were successfuly done. And no any errors shown during publishing of those Instances from testing steps.

BigRoy
BigRoy reviewed Oct 24, 2023
View reviewed changes
BigRoy
BigRoy approved these changes Dec 11, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test it - but code changes look good to me. Very nice cleanup!

Only thing I wonder is whether we should rename the extract_pointcache.py file to extract_alembic.py since it now contains multiple extractors.

@mkolar
Copy link
Copy Markdown
Member

mkolar commented Dec 11, 2023

Didn't test it - but code changes look good to me. Very nice cleanup!

Only thing I wonder is whether we should rename the extract_pointcache.py file to extract_alembic.py since it now contains multiple extractors.

I agree completely. Good work, but it's not extracting just pointcache anymore.

LiborBatek
LiborBatek approved these changes Dec 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Publish went ok... without any issues. Tested in both legacy OP and Ayon mode.

image

@moonyuet moonyuet merged commit 43cd2fd into develop Dec 15, 2023
@moonyuet moonyuet deleted the enhancement/OP-7133_3dsMax--optional-custom-attributes-for-abc-extract branch December 15, 2023 11:21
@ynbot ynbot added this to the next-patch milestone Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@antirotor antirotor Awaiting requested review from antirotor

2 more reviewers

@BigRoy BigRoy BigRoy approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LiborBatek LiborBatek

Labels

host: 3dsmax Autodesk 3dsmax size/S Denotes a PR changes 100-499 lines, ignoring general files type: enhancement Enhancements to existing functionality

Projects

PR reviewing
Archived in project

Milestone

3.18.2

Development

Successfully merging this pull request may close these issues.

5 participants

@moonyuet @ynbot @mkolar @BigRoy @LiborBatek