Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Houdini: Add self publish button#5621

Merged
antirotor merged 22 commits intodevelopfrom
tests/houdini_rops-self-publish-button
Oct 18, 2023
Merged

Houdini: Add self publish button#5621
antirotor merged 22 commits intodevelopfrom
tests/houdini_rops-self-publish-button

Conversation

@MustafaJafar
Copy link
Copy Markdown
Member

@MustafaJafar MustafaJafar commented Sep 14, 2023 •
edited
Loading

Changelog Description

This PR allows single publishing by adding a publish button to created rop nodes in Houdini

OpenPype Ayon

Admins are much welcomed to enable it from houdini general settings

OpenPype Ayon

Publish Button also includes all input publish instances.
in this screen shot the alembic instance is ignored because the switch is turned off
image

Additional info

This PR was made to prototype Fabia's idea about publishing one instance in houdini, discord discussion

Testing notes:

  1. Create multiple publish instances in houdini
  2. try publishing from the button

@MustafaJafar MustafaJafar marked this pull request as draft September 14, 2023 18:15
@ynbot ynbot added host: Houdini size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Sep 14, 2023
BigRoy
BigRoy reviewed Sep 14, 2023
View reviewed changes
Comment thread openpype/hosts/houdini/api/lib.py Outdated
Comment thread openpype/hosts/houdini/api/lib.py Outdated
Comment thread openpype/hosts/houdini/api/lib.py Outdated
Comment thread openpype/hosts/houdini/api/lib.py Outdated
Comment thread openpype/hosts/houdini/api/lib.py Outdated
Comment thread openpype/hosts/houdini/api/lib.py Outdated
Comment thread openpype/hosts/houdini/api/plugin.py Outdated
@fabiaserra
Copy link
Copy Markdown
Contributor

fabiaserra commented Sep 14, 2023

as I said on Discord, could we also expose a string parm called "Comment" (or a pop-up dialog after clicking Publish) where they can type the comment corresponding to that publish?

@fabiaserra
Copy link
Copy Markdown
Contributor

fabiaserra commented Sep 14, 2023

I like it! Thanks for doing this! I will test it soon

@MustafaJafar MustafaJafar requested a review from BigRoy September 15, 2023 07:36
iLLiCiTiT
iLLiCiTiT reviewed Sep 15, 2023
View reviewed changes
Comment thread openpype/hosts/houdini/api/lib.py Outdated
iLLiCiTiT
iLLiCiTiT reviewed Sep 15, 2023
View reviewed changes
Comment thread openpype/hosts/houdini/api/lib.py
iLLiCiTiT
iLLiCiTiT reviewed Sep 15, 2023
View reviewed changes
Comment thread openpype/hosts/houdini/api/lib.py Outdated
BigRoy
BigRoy reviewed Sep 15, 2023
View reviewed changes
Comment thread openpype/hosts/houdini/api/lib.py Outdated
BigRoy
BigRoy reviewed Sep 15, 2023
View reviewed changes
Comment thread openpype/hosts/houdini/api/lib.py Outdated
BigRoy
BigRoy reviewed Sep 15, 2023
View reviewed changes
Comment thread openpype/tools/publisher/window.py Outdated
@MustafaJafar MustafaJafar marked this pull request as ready for review September 22, 2023 09:09
@moonyuet
Copy link
Copy Markdown
Member

moonyuet commented Oct 9, 2023

@antirotor I think this PR is ready for review and merge

@MustafaJafar
Copy link
Copy Markdown
Member Author

MustafaJafar commented Oct 10, 2023 •
edited
Loading

@antirotor I think this PR is ready for review and merge

I think we would need @iLLiCiTiT review too because I modified the publisher a little bit.

Quick recap
This PR provides a quick way to specify what nodes to publish in a "Houdini way" where we connect ROPs to each other and click publish button.

It automates the current workflow and it doesn't enable procedural workflows.
Houdini does provide me with the execution order of nodes but I cannot use this information in any way.

antirotor
antirotor approved these changes Oct 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and the code looks good. This is one step on a path to make OP/AYON workflow in Houdini more native a procedural but even in this form, it is useful. Thanks @MustafaJafar

iLLiCiTiT
iLLiCiTiT reviewed Oct 17, 2023
View reviewed changes
Comment thread openpype/hosts/houdini/api/lib.py Outdated
iLLiCiTiT
iLLiCiTiT reviewed Oct 17, 2023
View reviewed changes
Comment thread openpype/hosts/houdini/api/plugin.py Outdated
iLLiCiTiT
iLLiCiTiT reviewed Oct 17, 2023
View reviewed changes
Comment thread openpype/hosts/houdini/api/lib.py Outdated
@iLLiCiTiT
Copy link
Copy Markdown
Member

iLLiCiTiT commented Oct 17, 2023

Moved the show and publish logic to Publisher window, which reduced public functions of the window. Also removed reset_on_show argument from host tools. The proper implementation of the functionality would be more complicated. Please re-test if still works as before.

BigRoy
BigRoy reviewed Oct 17, 2023
View reviewed changes
Comment thread openpype/hosts/houdini/api/lib.py Outdated
@antirotor @BigRoy
Update openpype/hosts/houdini/api/lib.py
e6ac57b 
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@antirotor
Copy link
Copy Markdown
Member

antirotor commented Oct 17, 2023

First time publish will (probably) publish stuff ok, but then it will reset the UI and the publishing report/state will be lost. Subsequent publishes are ok.

@MustafaJafar
Copy link
Copy Markdown
Member Author

MustafaJafar commented Oct 17, 2023

I tested it many times, seems to work fine.

antirotor
antirotor approved these changes Oct 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the reset fix, it works!

@antirotor antirotor merged commit b1dbbcd into develop Oct 18, 2023
@antirotor antirotor deleted the tests/houdini_rops-self-publish-button branch October 18, 2023 14:22
@ynbot ynbot added this to the next-patch milestone Oct 18, 2023
@MustafaJafar MustafaJafar mentioned this pull request Oct 18, 2023
Merged
@BigRoy BigRoy mentioned this pull request Oct 18, 2023
Merged
@MustafaJafar MustafaJafar mentioned this pull request Oct 19, 2023
Merged
5 tasks
@moonyuet moonyuet mentioned this pull request Jul 8, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@moonyuet moonyuet Awaiting requested review from moonyuet

@BigRoy BigRoy Awaiting requested review from BigRoy

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

2 more reviewers

@fabiaserra fabiaserra fabiaserra approved these changes

@antirotor antirotor antirotor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iLLiCiTiT iLLiCiTiT

Labels

host: Houdini size/XS Denotes a PR changes 0-99 lines, ignoring general files

Projects

PR reviewing
Archived in project

Milestone

3.17.3

Development

Successfully merging this pull request may close these issues.

8 participants

@MustafaJafar @fabiaserra @BigRoy @moonyuet @krishnaavril @iLLiCiTiT @antirotor @ynbot