Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Add kitsu credentials to deadline publish job #5455

Merged
mkolar merged 1 commit intodevelopfrom
bugfix/add_kitsu_credentials_to_publish_job
Aug 24, 2023
Merged

Add kitsu credentials to deadline publish job #5455
mkolar merged 1 commit intodevelopfrom
bugfix/add_kitsu_credentials_to_publish_job

Conversation

@MustafaJafar
Copy link
Copy Markdown
Member

Changelog Description

This PR hopefully fixes this issue #5440

Additional Info

This solution was a dumb test that worked!
I don't know if it covers all the cases (e.g. Muster)

Testing notes:

  1. enable kitsu module
  2. submit a deadline job

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working module: Deadline AWS Deadline related features labels Aug 16, 2023
@MustafaJafar MustafaJafar added the module: Kitsu Kitsu integration label Aug 16, 2023
@MustafaJafar MustafaJafar linked an issue Aug 16, 2023 that may be closed by this pull request
2 tasks
@moonyuet
Copy link
Copy Markdown
Member

Code looks good for me
Tested it without kitsu it works fine
image

@azhagurajpandians
Copy link
Copy Markdown

PR works for me, Kitsu Publish works now
deadlinemonitor_S8o67YD4Mm

Copy link
Copy Markdown

@azhagurajpandians azhagurajpandians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kitsu publish works for me !
deadlinemonitor_S8o67YD4Mm

@mkolar mkolar merged commit d787b74 into develop Aug 24, 2023
@ynbot ynbot added this to the next-patch milestone Aug 24, 2023
@mkolar mkolar deleted the bugfix/add_kitsu_credentials_to_publish_job branch October 4, 2023 20:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

module: Deadline AWS Deadline related features module: Kitsu Kitsu integration size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Bug: Deadline publish job fail because of collect kitsu credentials

5 participants