Maya: Cant assign shaders to the ass file - OP-4859 by tokejepsen · Pull Request #4460 · ynput/OpenPype

tokejepsen · 2023-02-14T15:10:16Z

Brief description

Support AiStandIn nodes for look assignment.

Description

Using operators we assign shaders and attribute/parameters to nodes within standins. Initially there is only support for a limited mount of attributes but we can add support as needed;

primaryVisibility
castsShadows
receiveShadows
aiSelfShadows
aiOpaque
aiMatte
aiVisibleInDiffuseTransmission
aiVisibleInSpecularTransmission
aiVisibleInVolume
aiVisibleInDiffuseReflection
aiVisibleInSpecularReflection
aiSubdivUvSmoothing
aiDispHeight
aiDispPadding
aiDispZeroValue
aiStepSize
aiVolumePadding
aiSubdivType
aiSubdivIterations

Testing notes

Load an alembic and lookdev, plus publish the look.
Load the same alembic and publish as Arnold Scene Source.
Load the publish Arnold Scene Source and assign the publish look through the LookManager.

Resolves #4535

…e-ass-file

…e/OP-4859_cant-assign-shaders-to-the-ass-file

ynbot · 2023-02-14T15:10:21Z

Task linked: OP-4859 Can’t assign shaders to the ASS file

…e-ass-file

tokejepsen · 2023-02-27T15:36:09Z

Look at #4535

…e-ass-file

- refactor common code to lib.

tokejepsen · 2023-03-01T12:22:41Z

@LiborBatek give this another go. Think I've fixed #4535 now.

…e-ass-file # Conflicts: # openpype/hosts/maya/api/lib.py # openpype/hosts/maya/tools/mayalookassigner/arnold_standin.py # openpype/hosts/maya/tools/mayalookassigner/lib.py

BigRoy

Some notes

openpype/hosts/maya/plugins/publish/collect_arnold_scene_source.py

openpype/hosts/maya/plugins/publish/extract_arnold_scene_source.py

openpype/hosts/maya/plugins/publish/validate_arnold_scene_source_cbid.py

openpype/hosts/maya/tools/mayalookassigner/app.py

openpype/hosts/maya/tools/mayalookassigner/arnold_standin.py

openpype/hosts/maya/tools/mayalookassigner/commands.py

LiborBatek · 2023-03-31T10:20:51Z

@LiborBatek what version of Maya and MTOA are you running?

maya 2023.3 + arnold 5.1.3.3

tokejepsen · 2023-03-31T10:24:07Z

@LiborBatek could you try this again now?
I've replaced the ASS query with json sidecar, so it should be more stable now.

LiborBatek

Now its possible to assign Look asset to the Ass Instance loaded in scene as with other representations of the model.

So working ok.

Not sure why but I m not able to graph it in Hypershade editor its not shown as connected shader to the ass asset. Maybe its by its nature just a reminder what observed during testing....could be issue later on.

tokejepsen · 2023-03-31T15:50:05Z

Not sure why but I m not able to graph it in Hypershade editor its not shown as connected shader to the ass asset. Maybe its by its nature just a reminder what observed during testing....could be issue later on.

Yeah, assigning shaders to aiStandIn is done through operators, which do not follow any native material assignments workflows.; https://help.autodesk.com/view/ARNOL/ENU/?guid=arnold_user_guide_ac_operators_html

tokejepsen · 2023-03-31T15:50:31Z

@BigRoy you happy with this PR?

openpype/hosts/maya/plugins/publish/extract_arnold_scene_source.py

openpype/hosts/maya/tools/mayalookassigner/arnold_standin.py

openpype/hosts/maya/plugins/publish/extract_arnold_scene_source.py

…e.py Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

…ttps://github.com/tokejepsen/pype into feature/OP-4859_cant-assign-shaders-to-the-ass-file

…e.py

…ttps://github.com/tokejepsen/pype into feature/OP-4859_cant-assign-shaders-to-the-ass-file

tokejepsen · 2023-04-02T16:35:02Z

@moonyuet or @LiborBatek could I get an approval on this?

LiborBatek

Seems ok. Being already tested.

OlivierOsotimehin · 2023-04-15T19:57:20Z

Hello,
This feature will be so great if it also worked on .abc loaded through the standin. This mean we could load animation caches directly in .abc and apply the look on them without the need to réexport in .ass

tokejepsen · 2023-04-16T08:50:31Z

@OlivierOsotimehin it does work on abc representations :⁠-⁠)

tokejepsen added 3 commits February 14, 2023 07:35

Merge branch 'develop' into feature/OP-4859_cant-assign-shaders-to-th…

a9989a9

…e-ass-file

Merge branch 'enhancement/OP-4865_static-ass-file-option' into featur…

493fd7f

…e/OP-4859_cant-assign-shaders-to-the-ass-file

Publish cbid with ass files.

6bd9321

tokejepsen added host: Maya type: feature Larger, user affecting changes and completely new things labels Feb 14, 2023

tokejepsen self-assigned this Feb 14, 2023

tokejepsen added 11 commits February 15, 2023 12:27

Working shader assignments

d4c0016

Better support for namespace when publishing ASS

fafd55c

Fix loading ASS

cbb0477

Support attribute assignments

cf4fd97

Fix collecting and assigning enum values

2cb2ba0

Support displacement shader

0e70a95

Support more parameters.

d13b74c

Refactor to share code between vray and arnold

70b607b

Missing refactor code

c426e34

Hound

017d85d

Merge branch 'develop' into feature/OP-4859_cant-assign-shaders-to-th…

455cb65

…e-ass-file

tokejepsen requested a review from LiborBatek February 16, 2023 15:16

tokejepsen marked this pull request as ready for review February 16, 2023 15:16

tokejepsen assigned LiborBatek and unassigned tokejepsen Feb 21, 2023

tokejepsen added 2 commits March 1, 2023 08:36

Merge branch 'develop' into feature/OP-4859_cant-assign-shaders-to-th…

484a14c

…e-ass-file

Get all descendents in collector.

d770547

- refactor common code to lib.

tokejepsen requested a review from m-u-r-p-h-y March 16, 2023 14:23

tokejepsen assigned m-u-r-p-h-y Mar 16, 2023

Merge branch 'develop' into feature/OP-4859_cant-assign-shaders-to-th…

143cd46

…e-ass-file # Conflicts: # openpype/hosts/maya/api/lib.py # openpype/hosts/maya/tools/mayalookassigner/arnold_standin.py # openpype/hosts/maya/tools/mayalookassigner/lib.py

BigRoy reviewed Mar 16, 2023

View reviewed changes

Use json sidecar instead of querying ass file for IDs.

10fdeb5

LiborBatek self-requested a review March 31, 2023 15:43

LiborBatek previously approved these changes Mar 31, 2023

View reviewed changes

BigRoy reviewed Mar 31, 2023

View reviewed changes

openpype/hosts/maya/plugins/publish/extract_arnold_scene_source.py Outdated Show resolved Hide resolved

BigRoy reviewed Mar 31, 2023

View reviewed changes

openpype/hosts/maya/tools/mayalookassigner/arnold_standin.py Show resolved Hide resolved

BigRoy reviewed Mar 31, 2023

View reviewed changes

openpype/hosts/maya/tools/mayalookassigner/arnold_standin.py Show resolved Hide resolved

BigRoy reviewed Mar 31, 2023

View reviewed changes

openpype/hosts/maya/plugins/publish/extract_arnold_scene_source.py Show resolved Hide resolved

Update openpype/hosts/maya/plugins/publish/extract_arnold_scene_sourc…

26d1c8d

…e.py Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

tokejepsen dismissed LiborBatek’s stale review via 26d1c8d March 31, 2023 16:25

tokejepsen added 6 commits March 31, 2023 17:53

Doc string for shading_engine_assignments

9011316

Merge branch 'feature/OP-4859_cant-assign-shaders-to-the-ass-file' of h…

7b17e1d

…ttps://github.com/tokejepsen/pype into feature/OP-4859_cant-assign-shaders-to-the-ass-file

Update openpype/hosts/maya/plugins/publish/extract_arnold_scene_sourc…

89f9003

…e.py

Log

e244778

Merge branch 'feature/OP-4859_cant-assign-shaders-to-the-ass-file' of h…

dd6dedf

…ttps://github.com/tokejepsen/pype into feature/OP-4859_cant-assign-shaders-to-the-ass-file

Hound

b17f521

LiborBatek self-requested a review April 3, 2023 11:19

LiborBatek approved these changes Apr 3, 2023

View reviewed changes

antirotor approved these changes Apr 3, 2023

View reviewed changes

antirotor merged commit 4f0fed1 into ynput:develop Apr 3, 2023

ynbot added this to the next-patch milestone Apr 3, 2023

tokejepsen deleted the feature/OP-4859_cant-assign-shaders-to-the-ass-file branch April 3, 2023 15:15

BigRoy mentioned this pull request Apr 18, 2023

Maya: Support .abc files directly for Arnold standin look assignment #4856

Merged

tokejepsen mentioned this pull request Jan 30, 2024

Arnold Scene Source Raw - OP-8014 #6182

Merged

Conversation

tokejepsen commented Feb 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Brief description

Description

Testing notes

Uh oh!

ynbot commented Feb 14, 2023

Uh oh!

tokejepsen commented Feb 27, 2023

Uh oh!

tokejepsen commented Mar 1, 2023

Uh oh!

BigRoy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LiborBatek commented Mar 31, 2023

Uh oh!

tokejepsen commented Mar 31, 2023

Uh oh!

LiborBatek left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tokejepsen commented Mar 31, 2023

Uh oh!

tokejepsen commented Mar 31, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tokejepsen commented Apr 2, 2023

Uh oh!

LiborBatek left a comment

Choose a reason for hiding this comment

Uh oh!

OlivierOsotimehin commented Apr 15, 2023

Uh oh!

tokejepsen commented Apr 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

tokejepsen commented Feb 14, 2023 •

edited

Loading

LiborBatek left a comment •

edited

Loading