Skip to content

Disable colors in tests#19

Closed
cjwatson wants to merge 1 commit intoynikitenko:masterfrom
cjwatson:py314-test-disable-colors
Closed

Disable colors in tests#19
cjwatson wants to merge 1 commit intoynikitenko:masterfrom
cjwatson:py314-test-disable-colors

Conversation

@cjwatson
Copy link
Contributor

@cjwatson cjwatson commented Jan 6, 2026

Several tests fail on Python 3.14 due to argparse making additional fileno calls to check for color support. This isn't interesting in tests at the moment, so disable it.

Several tests fail on Python 3.14 due to `argparse` making additional
`fileno` calls to check for color support.  This isn't interesting in
tests at the moment, so disable it.
@ynikitenko
Copy link
Owner

Hi @cjwatson, many thanks for your contribution. I am using Manjaro now instead of Arch Linux, so I did not test Python 3.14 before.
There was a more general problem with mock calls unstable between Python versions. I have (hopefully) fixed that in #21 .
In that case your tests should also pass (tox does not always show that). Please check.
I think the more general solution was better, since it is more robust: we do not depend on third-party tools introducing different calls in different Python versions.
Does this work for you?

@cjwatson
Copy link
Contributor Author

cjwatson commented Feb 8, 2026

Yes, that approach works fine for me. Thanks!

@cjwatson cjwatson closed this Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants