fix: can't use GET request for signed uploads

carlalexander · carlalexander · commit 93faa4810934 · 2021-03-09T17:31:53.000-05:00
diff --git a/src/ApiClient.php b/src/ApiClient.php
@@ -645,7 +645,7 @@ public function getSignedAssetRequests(int $deploymentId, array $assets): Collec
      */
     public function getSignedUploadRequests(int $projectId, string $environment, array $uploads): Collection
     {
-        $requests = $this->request('get', "/projects/{$projectId}/environments/{$environment}/signed-uploads", ['uploads' => $uploads]);
+        $requests = $this->request('post', "/projects/{$projectId}/environments/{$environment}/signed-uploads", ['uploads' => $uploads]);
 
         if (!empty($uploads) && empty($requests)) {
             throw new RuntimeException('Unable to get authorized uploads requests from the Ymir API');
diff --git a/src/Command/Import/ImportUploadsCommand.php b/src/Command/Import/ImportUploadsCommand.php
@@ -158,6 +158,7 @@ private function createTempDirectory(): string
         }
 
         $attempts = 0;
+
         do {
             ++$attempts;
             $tmpDirectory = sprintf('%s%s%s', $baseDirectory, 'ymir_', mt_rand(100000, mt_getrandmax()));

Original file line number	Diff line number	Diff line change
`@@ -645,7 +645,7 @@ public function getSignedAssetRequests(int $deploymentId, array $assets): Collec`
`645`	`645`	`*/`
`646`	`646`	`public function getSignedUploadRequests(int $projectId, string $environment, array $uploads): Collection`
`647`	`647`	`{`
`648`		`- $requests = $this->request('get', "/projects/{$projectId}/environments/{$environment}/signed-uploads", ['uploads' => $uploads]);`
	`648`	`+ $requests = $this->request('post', "/projects/{$projectId}/environments/{$environment}/signed-uploads", ['uploads' => $uploads]);`
`649`	`649`
`650`	`650`	`if (!empty($uploads) && empty($requests)) {`
`651`	`651`	`throw new RuntimeException('Unable to get authorized uploads requests from the Ymir API');`
Original file line number	Diff line number	Diff line change
`@@ -158,6 +158,7 @@ private function createTempDirectory(): string`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`$attempts = 0;`
	`161`	`+`
`161`	`162`	`do {`
`162`	`163`	`++$attempts;`
`163`	`164`	`$tmpDirectory = sprintf('%s%s%s', $baseDirectory, 'ymir_', mt_rand(100000, mt_getrandmax()));`