Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Kevin, given that we are going to essentially throw away most of what was written in the poc binding, I've gone ahead and just squashed all of the changes between this change and master to clean up the history a bit. So, we can start fresh from here.
This PR has the minimal prosemirror <-> delta sync code that we had from the POC as a folder in
./src/sync. As well as, the sync-v2 that we discussed at the end of the POC (still in progress & very much not usable yet) in./src/plugins/sync.Next week I should have more time to get into this. But, for now, this should give you a base to start working on the prosemirror <-> delta binding.
I've not even tried to upgrade lib0 or Y.js so the API is likely incompatible right now, but at least we have a shared start from here