Skip to content

Setup psalm level to 2#504

Merged
samdark merged 20 commits into3.0from
psalm
Nov 23, 2023
Merged

Setup psalm level to 2#504
samdark merged 20 commits into3.0from
psalm

Conversation

@s1lver
Copy link
Copy Markdown
Member

@s1lver s1lver commented Nov 20, 2023

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues

@s1lver s1lver added the type:enhancement Enhancement label Nov 20, 2023
@s1lver s1lver added this to the 3.0.0 milestone Nov 20, 2023
@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Nov 20, 2023

PR Summary

  • Dependency Updates

    • The versions for dependencies "pda/pheanstalk", "aws/aws-sdk-php", and "vimeo/psalm" have been updated to maintain code compatibility and leverage new features or improvements.
  • Configuration File Updates

    • Certain exclusions have been added in the phpunit.xml.dist configuration file which basically directs our testing tool to ignore certain directories.
    • Default error level has been lowered in the psalm.xml configuration file which tightens our code analysis checks.
  • Codebase Updates

    • Type hinting has been added in various files. This specifies what type of data (integer, string, etc.) a function expects to receive, improving the predictability and stability of the code.
    • Read-only modifier has been added to certain properties, enhancing the code security by preventing unwanted changes.
    • Default values have been provided to certain properties, this reduces the chance of "undefined" errors.
    • Some methods have been updated for better data handling.
  • New File Additions

    • New files have been added - one such example is src/RetryableJobInterface.php. These files add new functionalities to the codebase.
  • File and Property Renaming / Method Adjustment

    • Renaming of some properties for improved readability and code clarity.
    • Adjustments made to some methods for better error handling and performance.
    • Introduced file and method changes to handle specific tasks/error across the codebase.
  • Codebase Refactoring

    • Several changes have been made to enhance the performance of the codebase, simplify its complexity, and improve the code readability. For example, in Queue.php file, instantiation of $this->serializer has been moved to its own method getSerializer().
  • Exception handling Updates

    • Some of the try-catch block has been changed to use Throwable instead of \Exception|\Throwable for better error tracking and handling.
  • Test Suite Enhancements

    • The test suite has been updated to maintain the test compatibility with the rest of the codebase. Tests for newly added functionalities have also been incorporated.

Most of these changes are meant to improve the stability, performance, and readability of the code. This will potentially reduce future bugs, make the code easier to navigate, and enhance the efficiency of the system.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (3.0@67637f5). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             3.0     #504   +/-   ##
======================================
  Coverage       ?   32.69%           
  Complexity     ?      453           
======================================
  Files          ?       39           
  Lines          ?     1456           
  Branches       ?        0           
======================================
  Hits           ?      476           
  Misses         ?      980           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark merged commit f915784 into 3.0 Nov 23, 2023
@samdark samdark deleted the psalm branch November 23, 2023 13:52
@samdark
Copy link
Copy Markdown
Member

samdark commented Nov 23, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants