Refactor linter configuration and update Composer scripts for improved code quality checks.#260
Merged
terabytesoftw merged 5 commits intoyiisoft:masterfrom Mar 5, 2026
Merged
Conversation
Member
terabytesoftw
commented
Mar 4, 2026
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Tests pass? | ❌ |
…d code quality checks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
============================================
+ Coverage 98.14% 98.17% +0.03%
- Complexity 268 269 +1
============================================
Files 16 16
Lines 756 769 +13
============================================
+ Hits 742 755 +13
Misses 14 14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR refactors how code style checks are configured and invoked by moving the target directories into phpcs.xml.dist, then updating Composer scripts and CI to rely on that centralized configuration.
Changes:
- Configure PHPCS to scan
srcandtestsviaphpcs.xml.dist. - Update Composer
cs/cs-fixscripts to run PHPCS/PHPCBF without explicit path arguments. - Fix documentation heading/linking and simplify the linter workflow configuration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
phpcs.xml.dist |
Adds src and tests as configured scan targets for PHPCS. |
composer.json |
Updates code-style scripts to rely on the PHPCS ruleset configuration. |
docs/guide/internals.md |
Corrects the document title to match the page purpose. |
README.md |
Fixes the Internals documentation link to the correct path. |
.github/workflows/linter.yml |
Removes explicit directory inputs to align CI with the new PHPCS configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samdark
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.