Fix deprecated tests in PHP 8.5.#256
Merged
terabytesoftw merged 4 commits intoyiisoft:masterfrom Feb 14, 2026
Merged
Conversation
Member
terabytesoftw
commented
Feb 11, 2026
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Tests pass? | ❌ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #256 +/- ##
=========================================
Coverage 98.14% 98.14%
Complexity 268 268
=========================================
Files 16 16
Lines 756 756
=========================================
Hits 742 742
Misses 14 14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR updates the test suite to avoid PHP 8.5-related deprecations/compatibility issues so the extension’s CI can run cleanly on newer PHP versions.
Changes:
- Adjusted the test helper
invoke()implementation intests/TestCase.php. - Updated
MessageTest::testHasCookies()to construct aCookiewith an explicitname. - Added a changelog entry for the fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/TestCase.php | Alters the reflection-based helper used by many tests to call non-public methods. |
| tests/MessageTest.php | Updates cookie creation in a test to match newer expectations. |
| CHANGELOG.md | Records the test fixes in the project changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8.5.8.5.
8.5.8.5,
8.5,8.5.
mspirkov
reviewed
Feb 11, 2026
mspirkov
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.