fixStreamGetContentsArgumentError#250
Merged
samdark merged 13 commits intoyiisoft:masterfrom Aug 26, 2025
Merged
Conversation
Contributor
shaperman
commented
Aug 15, 2025
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues |
…st be of type resource, bool given
…st be of type resource, bool given
Member
terabytesoftw
requested changes
Aug 15, 2025
fix: support for PHP 5
terabytesoftw
approved these changes
Aug 15, 2025
samdark
requested changes
Aug 17, 2025
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
samdark
reviewed
Aug 18, 2025
Member
|
That solves the issue but, I think, we have more places like that. I don't particularly like how it was solved in Yii2 in the first place. For Yii3, we did it like the following: https://github.com/yiisoft/files/blob/master/src/FileHelper.php#L71 |
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
Member
We should then adapt the best solution, and identify where to apply it to do so. |
samdark
reviewed
Aug 19, 2025
Member
|
Current implementation is missing closing of the steam in catch block as well. |
Member
|
@terabytesoftw would you please check why tests fail in master? |
Member
1) yiiunit\extensions\httpclient\StreamTransportTest::testSendError
Undefined variable: stream
/home/runner/work/yii2-httpclient/yii2-httpclient/src/StreamTransport.php:71
/home/runner/work/yii2-httpclient/yii2-httpclient/src/Client.php:233
/home/runner/work/yii2-httpclient/yii2-httpclient/src/Request.php:451
/home/runner/work/yii2-httpclient/yii2-httpclient/tests/TransportTestCase.php:141
phpvfscomposer:///home/runner/work/yii2-httpclient/yii2-httpclient/vendor/phpunit/phpunit/phpunit:51
/home/runner/work/yii2-httpclient/yii2-httpclient/vendor/bin/phpunit:118
2) yiiunit\extensions\httpclient\StreamTransportTest::testInvalidUrl
Undefined variable: stream
/home/runner/work/yii2-httpclient/yii2-httpclient/src/StreamTransport.php:71
/home/runner/work/yii2-httpclient/yii2-httpclient/src/Client.php:233
/home/runner/work/yii2-httpclient/yii2-httpclient/src/Request.php:451
/home/runner/work/yii2-httpclient/yii2-httpclient/tests/TransportTestCase.php:254
phpvfscomposer:///home/runner/work/yii2-httpclient/yii2-httpclient/vendor/phpunit/phpunit/phpunit:51
/home/runner/work/yii2-httpclient/yii2-httpclient/vendor/bin/phpunit:118 |
samdark
approved these changes
Aug 26, 2025
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.