Skip to content

Refactor linter configuration and update Composer scripts for improved code quality checks.#551

Merged
terabytesoftw merged 7 commits intoyiisoft:masterfrom
terabytesoftw:fix_linter_1
Mar 5, 2026
Merged

Refactor linter configuration and update Composer scripts for improved code quality checks.#551
terabytesoftw merged 7 commits intoyiisoft:masterfrom
terabytesoftw:fix_linter_1

Conversation

@terabytesoftw
Copy link
Copy Markdown
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass?

@terabytesoftw terabytesoftw requested a review from a team March 4, 2026 09:12
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Mar 4, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.36%. Comparing base (bdeb8a8) to head (db2bce5).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #551   +/-   ##
=========================================
  Coverage     18.36%   18.36%           
  Complexity      657      657           
=========================================
  Files            78       78           
  Lines          3496     3496           
=========================================
  Hits            642      642           
  Misses         2854     2854           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s local/CI linting setup by shifting PHPCS directory selection into phpcs.xml.dist, simplifying Composer scripts accordingly, and refreshing the PHPStan baseline to match the current static analysis output.

Changes:

  • Update PHPCS configuration to explicitly scan src and tests, and simplify Composer cs / cs-fix scripts to rely on the ruleset.
  • Remove the directories input from the reusable GitHub Actions linter workflow invocation.
  • Refresh phpstan-baseline.neon entries and correct the heading in docs/internals.md.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
phpstan-baseline.neon Updates ignored PHPStan findings to match current analyzer output.
phpcs.xml.dist Adds <file> entries for src and tests so PHPCS scope is defined in config.
docs/internals.md Adjusts the top-level document heading.
composer.json Simplifies cs / cs-fix scripts to run PHPCS/PHPCBF using the ruleset defaults.
.github/workflows/linter.yml Removes explicit directories passed to the reusable linter workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@terabytesoftw terabytesoftw merged commit 587dd75 into yiisoft:master Mar 5, 2026
18 checks passed
@terabytesoftw terabytesoftw deleted the fix_linter_1 branch March 5, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants