Silence fetch errors#541
Merged
samdark merged 2 commits intoyiisoft:masterfrom Jul 8, 2025
Karkbauer:patch-1
Merged
Conversation
In cases when `fetch(...)` results in an error (for example, a network issue or the request is aborted), allow the call site to choose whether to ignore the error, or handle it. As the the toolbar has a separate promise chain, that the call site has no access to, rethrowing the error causes unnecessary noise in console logs when the error has already been handled by the call site.
This separate promise chain is not used after updating the `stackElement` array, so its safe to remove the rethrown error.
Before:
* Unhandled errors log two messages in console
* Handled errors log one message in console
After:
* Handled errors log one message in console
* Handled errors log none messages in console
An example where no error message is expected to be logged now:
```js
const controller = new AbortController();
fetch('/my/path', {signal: controller.signal})
.catch(e => {
if (e.name !== 'AbortError') {
throw e;
}
});
controller.abort();
```
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #541 +/- ##
=========================================
Coverage ? 46.07%
=========================================
Files ? 26
Lines ? 1593
Branches ? 0
=========================================
Hits ? 734
Misses ? 859
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samdark
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases when
fetch(...)results in an error (for example, a network issue or the request is aborted), allow the call site to choose whether to ignore the error, or handle it. As the the toolbar has a separate promise chain, that the call site has no access to, rethrowing the error causes unnecessary noise in console logs when the error has already been handled by the call site.This separate promise chain is not used after updating the
stackElementarray, so its safe to not rethrown error.Before:
After:
An example where no error message is expected to be logged now: