Prevent Alert widget from starting session unnecessarily.#335
Merged
terabytesoftw merged 2 commits intoyiisoft:masterfrom Mar 11, 2026
Merged
Prevent Alert widget from starting session unnecessarily.#335terabytesoftw merged 2 commits intoyiisoft:masterfrom
Alert widget from starting session unnecessarily.#335terabytesoftw merged 2 commits intoyiisoft:masterfrom
Conversation
Member
terabytesoftw
commented
Mar 11, 2026
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Tests pass? | ❌ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #335 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 44 46 +2
===========================================
Files 13 13
Lines 479 518 +39
===========================================
+ Hits 479 518 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR aims to avoid starting a Yii session when rendering the global Alert widget in requests where no session exists, reducing unnecessary session overhead (especially since the widget is rendered from the main layout on every page).
Changes:
- Short-circuit
Alert::run()when the session is inactive and no session id is present. - Update contact-form success handling to use a
successflash message with a user-facing message. - Add/adjust assets and tests related to the contact success view and the
Alertwidget behavior.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
widgets/Alert.php |
Skips flash rendering early when there is no session, avoiding session start. |
controllers/SiteController.php |
Sets a success flash with a message after successful contact submission. |
views/site/contact.php |
Switches success branch to hasFlash('success') and simplifies the success text. |
tests/Unit/widgets/AlertTest.php |
Adds a unit test intended to ensure the widget doesn’t start a session when none exists. |
docs/images/contact-success-light.png |
Adds a contact success screenshot asset. |
docs/images/contact-success-dark.png |
Adds a contact success screenshot asset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samdark
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.