Skip to content

Migrate to Bootstrap5.#333

Merged
terabytesoftw merged 9 commits intoyiisoft:masterfrom
terabytesoftw:migrate-bootstrap5
Mar 9, 2026
Merged

Migrate to Bootstrap5.#333
terabytesoftw merged 9 commits intoyiisoft:masterfrom
terabytesoftw:migrate-bootstrap5

Conversation

@terabytesoftw
Copy link
Copy Markdown
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass?

@terabytesoftw terabytesoftw requested review from a team and Copilot March 6, 2026 12:24
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Mar 6, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ee2ca48) to head (fffe4a0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #333   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        43        43           
===========================================
  Files             10        10           
  Lines            277       311   +34     
===========================================
+ Hits             277       311   +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the basic app UI toward Bootstrap 5.3+ styling, adds a client-side light/dark theme toggle, and updates linting configuration and documentation screenshots accordingly.

Changes:

  • Add Bootstrap 5.3-compatible color mode toggling (localStorage + data-bs-theme) and a navbar theme toggle button.
  • Refresh page layouts/styles (cards, navbar/footer colors, dark-mode tweaks like captcha inversion).
  • Simplify PHPCS invocation via phpcs.xml.dist, adjust CI linter workflow, and update README with screenshots/badges.

Reviewed changes

Copilot reviewed 15 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
web/js/color-mode.js Adds theme preference logic + navbar toggle behavior for Bootstrap color modes.
assets/AppAsset.php Registers the new theme JS in the document head.
views/layouts/main.php Adds data-bs-theme default and a navbar theme toggle button; adjusts navbar/footer classes.
web/css/site.css Updates colors to Bootstrap CSS variables; adds dark-mode tweaks for forms/captcha.
views/site/login.php Refactors login form markup to Bootstrap 5 input-group + floating label layout.
views/site/contact.php Refactors contact form markup similarly; adjusts captcha layout.
views/site/index.php Updates homepage layout to card-based Bootstrap 5 styling.
views/site/about.php Wraps file path in an alert for Bootstrap 5 look.
views/site/error.php Adds alert role + a “Go to Homepage” button and muted text styling.
tests/Unit/LogoutTest.php Updates expected logout button class string.
tests/Unit/LoginTest.php Updates expected logout button class string.
phpcs.xml.dist Defines directories to lint via PHPCS config.
composer.json Simplifies cs/cs-fix scripts to use PHPCS default config.
.github/workflows/linter.yml Removes explicit directories input to shared linter workflow.
README.md Adds responsive screenshots via <picture> and updates Docker badge link; adds License section.
docs/images/about-light.png Adds updated screenshot asset.
docs/images/about-dark.png Adds updated screenshot asset.
docs/images/contact-dark.png Adds updated screenshot asset.
docs/images/contact-light.png Adds updated screenshot asset.
docs/images/home-dark.png Adds updated screenshot asset.
docs/images/home-light.png Adds updated screenshot asset.
docs/images/login-dark.png Adds updated screenshot asset.
docs/images/login-light.png Adds updated screenshot asset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@terabytesoftw terabytesoftw requested a review from Copilot March 6, 2026 12:38
@terabytesoftw terabytesoftw changed the title Migrate bootstrap5. Migrate to Bootstrap5. Mar 6, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 23 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@terabytesoftw terabytesoftw merged commit 74655b7 into yiisoft:master Mar 9, 2026
13 checks passed
@terabytesoftw terabytesoftw deleted the migrate-bootstrap5 branch March 9, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants