Fix LinkPager::getPageRange when maxButtons assign with 2#20538
Merged
samdark merged 5 commits intoyiisoft:masterfrom Sep 27, 2025
Merged
Fix LinkPager::getPageRange when maxButtons assign with 2#20538samdark merged 5 commits intoyiisoft:masterfrom
LinkPager::getPageRange when maxButtons assign with 2#20538samdark merged 5 commits intoyiisoft:masterfrom
Conversation
Contributor
mspirkov
commented
Sep 21, 2025
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | #19655 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20538 +/- ##
=========================================
Coverage 64.53% 64.53%
- Complexity 11555 11556 +1
=========================================
Files 431 431
Lines 37581 37582 +1
=========================================
+ Hits 24252 24253 +1
Misses 13329 13329 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
terabytesoftw
approved these changes
Sep 21, 2025
Member
|
I think it would be great to check all the content generated by the widgets in the tests, and thus know exactly what it generates. What do you think? I plan to adopt it in the tests for the $this->assertEqualsWithoutLE(
<<<HTML
<div class="form-group field-dynamicmodel-name">
<input type="email" id="dynamicmodel-name" class="form-control" name="DynamicModel[name]" required>
</div>
HTML,
(string) $form
->field($model, 'name', $o)
->input('email', ['required' => true]),
); |
Contributor
Author
|
Good idea. I'll fix the added tests now. |
xicond
approved these changes
Sep 24, 2025
This was referenced Sep 26, 2025
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.