Fix renderer selection for view files with double extensions (#300)

vjik · web-flow · commit d9be20ca2572 · 2026-01-24T14:53:31.000+03:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - Enh #289: Add validation of renderers configuration to `ViewTrait::withRenderers()`  (@samdark)
 - Bug #295: Remove unnecessary `CacheKeyNormalizer` instance creation in `CachedContent` (@samdark)
 - Enh #295: Minor refactor `ViewTrait::getParameter()` and `ViewTrait::resolveViewFilePath()` (@samdark)
+- Bug #300: Fix renderer selection for view files with double extensions (@vjik)
 
 ## 12.2.2 December 07, 2025
 
diff --git a/src/ViewTrait.php b/src/ViewTrait.php
@@ -44,8 +44,12 @@ trait ViewTrait
     private array $fallbackExtensions = [self::PHP_EXTENSION];
 
     /**
-     * @var array A list of available renderers indexed by their corresponding
-     * supported file extensions.
+     * @var array A list of available renderers indexed by their corresponding supported file extensions.
+     *
+     * The renderers are stored in descending order by extension length (longest first).
+     * This ensures that more specific extensions (e.g., "blade.php") are matched before
+     * shorter ones (e.g., "php").
+     *
      * @psalm-var array<string, TemplateRendererInterface>
      */
     private array $renderers = [];
@@ -122,6 +126,11 @@ public function withRenderers(array $renderers): static
             }
         }
 
+        uksort(
+            $renderers,
+            static fn(string $a, string $b): int => strlen($b) <=> strlen($a)
+        );
+
         $new = clone $this;
         $new->renderers = $renderers;
         return $new;
@@ -477,9 +486,7 @@ public function render(string $view, array $parameters = []): string
         ];
 
         if ($this->beforeRender($viewFile, $parameters)) {
-            $ext = pathinfo($viewFile, PATHINFO_EXTENSION);
-            $renderer = $this->renderers[$ext] ?? new PhpTemplateRenderer();
-            $output = $renderer->render($this, $viewFile, $parameters);
+            $output = $this->getRenderer($viewFile)->render($this, $viewFile, $parameters);
             $output = $this->afterRender($viewFile, $parameters, $output);
         }
 
@@ -568,6 +575,27 @@ abstract protected function createAfterRenderEvent(
         string $result
     ): AfterRenderEventInterface;
 
+    /**
+     * Returns the appropriate template renderer for the given view file.
+     *
+     * Selects a renderer based on the view file extension. If no matching renderer is found
+     * for the file extension, returns a default {@see PhpTemplateRenderer}.
+     *
+     * @param string $viewFile The view file path.
+     *
+     * @return TemplateRendererInterface The template renderer instance.
+     */
+    private function getRenderer(string $viewFile): TemplateRendererInterface
+    {
+        $fileName = basename($viewFile);
+        foreach ($this->renderers as $extension => $renderer) {
+            if (str_ends_with($fileName, '.' . $extension)) {
+                return $renderer;
+            }
+        }
+        return new PhpTemplateRenderer();
+    }
+
     /**
      * This method is invoked right before {@see render()} renders a view file.
      *
diff --git a/tests/View/DoubleExtension/DoubleExtensionTest.php b/tests/View/DoubleExtension/DoubleExtensionTest.php
@@ -0,0 +1,62 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Yiisoft\View\Tests\View\DoubleExtension;
+
+use PHPUnit\Framework\TestCase;
+use Yiisoft\View\PhpTemplateRenderer;
+use Yiisoft\View\View;
+
+final class DoubleExtensionTest extends TestCase
+{
+    public function testBase(): void
+    {
+        $renderer = new TemplateRendererSpy();
+        $view = (new View(__DIR__ . '/views'))
+            ->withRenderers([
+                'blade.php' => $renderer,
+            ]);
+
+        $view->render('two.blade.php');
+
+        $this->assertSame(
+            [__DIR__ . '/views/two.blade.php'],
+            $renderer->getTemplates(),
+        );
+    }
+
+    public function testWithSeveralRenderers1(): void
+    {
+        $renderer = new TemplateRendererSpy();
+        $view = (new View(__DIR__ . '/views'))
+            ->withRenderers([
+                'blade.php' => $renderer,
+                'php' => new PhpTemplateRenderer(),
+            ]);
+
+        $view->render('two.blade.php');
+
+        $this->assertSame(
+            [__DIR__ . '/views/two.blade.php'],
+            $renderer->getTemplates(),
+        );
+    }
+
+    public function testWithSeveralRenderers2(): void
+    {
+        $renderer = new TemplateRendererSpy();
+        $view = (new View(__DIR__ . '/views'))
+            ->withRenderers([
+                'php' => new PhpTemplateRenderer(),
+                'blade.php' => $renderer,
+            ]);
+
+        $view->render('two.blade.php');
+
+        $this->assertSame(
+            [__DIR__ . '/views/two.blade.php'],
+            $renderer->getTemplates(),
+        );
+    }
+}
diff --git a/tests/View/DoubleExtension/TemplateRendererSpy.php b/tests/View/DoubleExtension/TemplateRendererSpy.php
@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Yiisoft\View\Tests\View\DoubleExtension;
+
+use Yiisoft\View\TemplateRendererInterface;
+use Yiisoft\View\ViewInterface;
+
+final class TemplateRendererSpy implements TemplateRendererInterface
+{
+    private array $templates = [];
+
+    public function getTemplates(): array
+    {
+        return $this->templates;
+    }
+
+    public function render(ViewInterface $view, string $template, array $parameters): string
+    {
+        $this->templates[] = $template;
+        return file_get_contents($template);
+    }
+}
diff --git a/tests/View/DoubleExtension/views/two.blade.php b/tests/View/DoubleExtension/views/two.blade.php
@@ -0,0 +1 @@
+2
