Fix #223: Make $content optional in Button factories (#238)

FrankiFixx · samdark · vjik · web-flow · commit cc467a7e05cf · 2025-01-19T12:35:51.000+03:00
Co-authored-by: Alexander Makarov &lt;sam@rmcreative.ru&gt;
Co-authored-by: Sergei Predvoditelev &lt;sergey.predvoditelev@gmail.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## 3.9.1 under development
 
 - Bug #232: Render `loading` attribute before `src` (@samdark)
+- Enh #223: Make `$content` parameter optional in `Button` factories (@FrankiFixx)
 
 ## 3.9.0 November 29, 2024
 
diff --git a/src/Tag/Button.php b/src/Tag/Button.php
@@ -14,21 +14,21 @@ final class Button extends NormalTag
 {
     use TagContentTrait;
 
-    public static function button(string $content): self
+    public static function button(string $content = ''): self
     {
         $button = self::tag()->content($content);
         $button->attributes['type'] = 'button';
         return $button;
     }
 
-    public static function submit(string $content): self
+    public static function submit(string $content = ''): self
     {
         $button = self::tag()->content($content);
         $button->attributes['type'] = 'submit';
         return $button;
     }
 
-    public static function reset(string $content): self
+    public static function reset(string $content = ''): self
     {
         $button = self::tag()->content($content);
         $button->attributes['type'] = 'reset';
diff --git a/tests/Tag/ButtonTest.php b/tests/Tag/ButtonTest.php
@@ -28,6 +28,30 @@ public function testButton(): void
         );
     }
 
+    public function testButtonWithoutContent(): void
+    {
+        $this->assertSame(
+            '<button type="button"></button>',
+            (string)Button::button()
+        );
+    }
+
+    public function testSubmitWithoutContent(): void
+    {
+        $this->assertSame(
+            '<button type="submit"></button>',
+            (string)Button::submit()
+        );
+    }
+
+    public function testResetWithoutContent(): void
+    {
+        $this->assertSame(
+            '<button type="reset"></button>',
+            (string)Button::reset()
+        );
+    }
+
     public function testSubmit(): void
     {
         $this->assertSame(

Original file line number	Diff line number	Diff line change
`@@ -14,21 +14,21 @@ final class Button extends NormalTag`
`14`	`14`	`{`
`15`	`15`	`use TagContentTrait;`
`16`	`16`
`17`		`- public static function button(string $content): self`
	`17`	`+ public static function button(string $content = ''): self`
`18`	`18`	`{`
`19`	`19`	`$button = self::tag()->content($content);`
`20`	`20`	`$button->attributes['type'] = 'button';`
`21`	`21`	`return $button;`
`22`	`22`	`}`
`23`	`23`
`24`		`- public static function submit(string $content): self`
	`24`	`+ public static function submit(string $content = ''): self`
`25`	`25`	`{`
`26`	`26`	`$button = self::tag()->content($content);`
`27`	`27`	`$button->attributes['type'] = 'submit';`
`28`	`28`	`return $button;`
`29`	`29`	`}`
`30`	`30`
`31`		`- public static function reset(string $content): self`
	`31`	`+ public static function reset(string $content = ''): self`
`32`	`32`	`{`
`33`	`33`	`$button = self::tag()->content($content);`
`34`	`34`	`$button->attributes['type'] = 'reset';`