Rename insertWithReturningPks() to insertReturningPks() (#361)

Tigrov · web-flow · commit e70cba00b831 · 2025-06-11T15:45:58.000+07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -40,7 +40,7 @@
 - New #355: Use `DateTimeColumn` class for datetime column types (@Tigrov)
 - New #356, #357: Implement `DMLQueryBuilder::upsertReturning()` method (@Tigrov)
 - Enh #356, #357: Refactor `Command::insertWithReturningPks()` and `DMLQueryBuilder::upsert()` methods (@Tigrov)
-- Enh #360: Implement `DMLQueryBuilder::insertWithReturningPks()` method (@Tigrov)
+- Enh #360, #361: Implement `DMLQueryBuilder::insertReturningPks()` method (@Tigrov)
 - Chg #362: Replace column and table name quote character from ` to " (@Tigrov)
 
 ## 1.2.0 March 21, 2024
diff --git a/src/DMLQueryBuilder.php b/src/DMLQueryBuilder.php
@@ -17,7 +17,7 @@
  */
 final class DMLQueryBuilder extends AbstractDMLQueryBuilder
 {
-    public function insertWithReturningPks(string $table, array|QueryInterface $columns, array &$params = []): string
+    public function insertReturningPks(string $table, array|QueryInterface $columns, array &$params = []): string
     {
         $insertSql = $this->insert($table, $columns, $params);
         $tableSchema = $this->schema->getTableSchema($table);
diff --git a/tests/Provider/QueryBuilderProvider.php b/tests/Provider/QueryBuilderProvider.php
@@ -112,7 +112,7 @@ public static function insert(): array
         return $insert;
     }
 
-    public static function insertWithReturningPks(): array
+    public static function insertReturningPks(): array
     {
         return [
             'regular-values' => [
diff --git a/tests/QueryBuilderTest.php b/tests/QueryBuilderTest.php
@@ -509,15 +509,15 @@ public function testInsert(
         parent::testInsert($table, $columns, $params, $expectedSQL, $expectedParams);
     }
 
-    #[DataProviderExternal(QueryBuilderProvider::class, 'insertWithReturningPks')]
-    public function testInsertWithReturningPks(
+    #[DataProviderExternal(QueryBuilderProvider::class, 'insertReturningPks')]
+    public function testInsertReturningPks(
         string $table,
         array|QueryInterface $columns,
         array $params,
         string $expectedSQL,
         array $expectedParams
     ): void {
-        parent::testInsertWithReturningPks($table, $columns, $params, $expectedSQL, $expectedParams);
+        parent::testInsertReturningPks($table, $columns, $params, $expectedSQL, $expectedParams);
     }
 
     public function testRenameColumn(): void

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@`
`17`	`17`	`*/`
`18`	`18`	`final class DMLQueryBuilder extends AbstractDMLQueryBuilder`
`19`	`19`	`{`
`20`		`- public function insertWithReturningPks(string $table, array\|QueryInterface $columns, array &$params = []): string`
	`20`	`+ public function insertReturningPks(string $table, array\|QueryInterface $columns, array &$params = []): string`
`21`	`21`	`{`
`22`	`22`	`$insertSql = $this->insert($table, $columns, $params);`
`23`	`23`	`$tableSchema = $this->schema->getTableSchema($table);`
Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ public static function insert(): array`
`112`	`112`	`return $insert;`
`113`	`113`	`}`
`114`	`114`
`115`		`- public static function insertWithReturningPks(): array`
	`115`	`+ public static function insertReturningPks(): array`
`116`	`116`	`{`
`117`	`117`	`return [`
`118`	`118`	`'regular-values' => [`