Conversation
Tigrov
commented
Jun 27, 2023
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues |
PR Summary
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
=========================================
Coverage 99.67% 99.67%
- Complexity 215 217 +2
=========================================
Files 13 13
Lines 619 622 +3
=========================================
+ Hits 617 620 +3
Misses 2 2
☔ View full report in Codecov by Sentry. |
| $loadColumnSchema->defaultValue($defaultValue === 'true'); | ||
| } elseif (is_string($defaultValue) && preg_match("/^B'(.*?)'::/", $defaultValue, $matches)) { | ||
| $loadColumnSchema->defaultValue(bindec($matches[1])); | ||
| } elseif (is_string($defaultValue) && preg_match("/^'(\d+)'::\"bit\"$/", $defaultValue, $matches)) { |
There was a problem hiding this comment.
Are you sure? Maybe oldest version return this format of default values? for example 9.0.1 and reading schema of view?
There was a problem hiding this comment.
Simple show me proof. Without adding tests. I want be sure.
There was a problem hiding this comment.
Are you sure? Maybe oldest version return this format of default values? for example 9.0.1 and reading schema of view?
- 9.6.0
There was a problem hiding this comment.
} elseif (is_string($defaultValue) && preg_match("/^B?'(.*?)'::/", $defaultValue, $matches)) {
This check match both "/^B'(.*?)'::/" and "/^'(\d+)'::\"bit\"$/"
And as the column of type bit it will be converted in ColumnSchema::phpTypecast()
|
@Tigrov please add line to changelog in other pr. I rushed to mergeю |