Rename getLastInsertID() method in ConnectionInterface to getLastInsertId() (#406)

vjik · web-flow · commit bca41879b6c3 · 2025-05-01T10:53:39.000+03:00
diff --git a/src/Connection.php b/src/Connection.php
@@ -51,13 +51,13 @@ public function getColumnFactory(): ColumnFactoryInterface
         return $this->columnFactory ??= new ColumnFactory();
     }
 
-    public function getLastInsertID(?string $sequenceName = null): string
+    public function getLastInsertId(?string $sequenceName = null): string
     {
         if ($sequenceName === null) {
             throw new InvalidArgumentException('PostgreSQL not support lastInsertId without sequence name.');
         }
 
-        return parent::getLastInsertID($sequenceName);
+        return parent::getLastInsertId($sequenceName);
     }
 
     public function getQueryBuilder(): QueryBuilderInterface
diff --git a/tests/PdoConnectionTest.php b/tests/PdoConnectionTest.php
@@ -41,7 +41,7 @@ public function testGetLastInsertID(): void
             ]
         )->execute();
 
-        $this->assertSame('4', $db->getLastInsertID('public.customer_id_seq'));
+        $this->assertSame('4', $db->getLastInsertId('public.customer_id_seq'));
 
         $db->close();
     }
@@ -63,7 +63,7 @@ public function testGetLastInsertIDWithException(): void
         $this->expectException(InvalidArgumentException::class);
         $this->expectExceptionMessage('PostgreSQL not support lastInsertId without sequence name.');
 
-        $db->getLastInsertID();
+        $db->getLastInsertId();
 
         $db->close();
     }

Original file line number	Diff line number	Diff line change
`@@ -51,13 +51,13 @@ public function getColumnFactory(): ColumnFactoryInterface`
`51`	`51`	`return $this->columnFactory ??= new ColumnFactory();`
`52`	`52`	`}`
`53`	`53`
`54`		`- public function getLastInsertID(?string $sequenceName = null): string`
	`54`	`+ public function getLastInsertId(?string $sequenceName = null): string`
`55`	`55`	`{`
`56`	`56`	`if ($sequenceName === null) {`
`57`	`57`	`throw new InvalidArgumentException('PostgreSQL not support lastInsertId without sequence name.');`
`58`	`58`	`}`
`59`	`59`
`60`		`- return parent::getLastInsertID($sequenceName);`
	`60`	`+ return parent::getLastInsertId($sequenceName);`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`public function getQueryBuilder(): QueryBuilderInterface`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function testGetLastInsertID(): void`
`41`	`41`	`]`
`42`	`42`	`)->execute();`
`43`	`43`
`44`		`- $this->assertSame('4', $db->getLastInsertID('public.customer_id_seq'));`
	`44`	`+ $this->assertSame('4', $db->getLastInsertId('public.customer_id_seq'));`
`45`	`45`
`46`	`46`	`$db->close();`
`47`	`47`	`}`
`@@ -63,7 +63,7 @@ public function testGetLastInsertIDWithException(): void`
`63`	`63`	`$this->expectException(InvalidArgumentException::class);`
`64`	`64`	`$this->expectExceptionMessage('PostgreSQL not support lastInsertId without sequence name.');`
`65`	`65`
`66`		`- $db->getLastInsertID();`
	`66`	`+ $db->getLastInsertId();`
`67`	`67`
`68`	`68`	`$db->close();`
`69`	`69`	`}`