Fix for typecast decimal columns (#228)

darkdef · web-flow · commit bc115d8a1d07 · 2023-02-06T21:42:04.000+03:00
diff --git a/tests/ColumnSchemaTest.php b/tests/ColumnSchemaTest.php
@@ -74,7 +74,7 @@ public function testPhpTypeCast(): void
         $this->assertSame(str_repeat('x', 100), $charColPhpTypeCast);
         $this->assertSame(1.234, $floatColPhpTypeCast);
         $this->assertFalse($boolColPhpTypeCast);
-        $this->assertSame('33.22', $numericColPhpTypeCast);
+        $this->assertSame(33.22, $numericColPhpTypeCast);
         $this->assertSame([1, -2, null, 42], $intArrayColPhpType);
         $this->assertNull($textArray2ColPhpType);
         $this->assertSame([['a' => 1, 'b' => null, 'c' => [1, 3, 5]]], $jsonColPhpType);
diff --git a/tests/Provider/QueryBuilderProvider.php b/tests/Provider/QueryBuilderProvider.php
@@ -360,7 +360,7 @@ public function insertWithReturningPks(): array
                 <<<SQL
                 INSERT INTO {{%order_item}} ("order_id", "item_id", "quantity", "subtotal") VALUES (:qp0, :qp1, :qp2, :qp3) RETURNING "order_id", "item_id"
                 SQL,
-                [':qp0' => 1, ':qp1' => 1, ':qp2' => 1, ':qp3' => '1',],
+                [':qp0' => 1, ':qp1' => 1, ':qp2' => 1, ':qp3' => 1.0,],
             ],
         ];
     }
diff --git a/tests/Provider/SchemaProvider.php b/tests/Provider/SchemaProvider.php
@@ -147,15 +147,15 @@ public function columns(): array
                     'numeric_col' => [
                         'type' => 'decimal',
                         'dbType' => 'numeric',
-                        'phpType' => 'string',
+                        'phpType' => 'double',
                         'primaryKey' => false,
                         'allowNull' => true,
                         'autoIncrement' => false,
                         'enumValues' => null,
                         'size' => null,
                         'precision' => 5,
                         'scale' => 2,
-                        'defaultValue' => '33.22',
+                        'defaultValue' => 33.22,
                     ],
                     'time' => [
                         'type' => 'timestamp',

Original file line number	Diff line number	Diff line change
`@@ -360,7 +360,7 @@ public function insertWithReturningPks(): array`
`360`	`360`	`<<<SQL`
`361`	`361`	`INSERT INTO {{%order_item}} ("order_id", "item_id", "quantity", "subtotal") VALUES (:qp0, :qp1, :qp2, :qp3) RETURNING "order_id", "item_id"`
`362`	`362`	`SQL,`
`363`		`- [':qp0' => 1, ':qp1' => 1, ':qp2' => 1, ':qp3' => '1',],`
	`363`	`+ [':qp0' => 1, ':qp1' => 1, ':qp2' => 1, ':qp3' => 1.0,],`
`364`	`364`	`],`
`365`	`365`	`];`
`366`	`366`	`}`