Change property Schema::$typeMap to constant Schema::TYPE_MAP (#248)

Tigrov · web-flow · commit ebb46454ea13 · 2023-11-16T09:10:43.000+03:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## 1.2.1 under development
 
-- no changes in this release.
+- Enh #248: Change property `Schema::$typeMap` to constant `Schema::TYPE_MAP` (@Tigrov)
 
 ## 1.2.0 November 12, 2023
 
diff --git a/src/Schema.php b/src/Schema.php
@@ -67,13 +67,13 @@
 final class Schema extends AbstractPdoSchema
 {
     /**
-     * @var array The mapping from physical column types (keys) to abstract column types (values).
+     * The mapping from physical column types (keys) to abstract column types (values).
      *
      * @link https://docs.oracle.com/en/database/oracle/oracle-database/23/sqlrf/Data-Types.html
      *
-     * @psalm-var string[]
+     * @var string[]
      */
-    private array $typeMap = [
+    private const TYPE_MAP = [
         'char' => self::TYPE_CHAR,
         'nchar' => self::TYPE_CHAR,
         'varchar2' => self::TYPE_STRING,
@@ -664,7 +664,7 @@ private function extractColumnType(ColumnSchemaInterface $column): string
             return self::TYPE_STRING;
         }
 
-        return $this->typeMap[$dbType] ?? self::TYPE_STRING;
+        return self::TYPE_MAP[$dbType] ?? self::TYPE_STRING;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -67,13 +67,13 @@`
`67`	`67`	`final class Schema extends AbstractPdoSchema`
`68`	`68`	`{`
`69`	`69`	`/**`
`70`		`- * @var array The mapping from physical column types (keys) to abstract column types (values).`
	`70`	`+ * The mapping from physical column types (keys) to abstract column types (values).`
`71`	`71`	`*`
`72`	`72`	`* @link https://docs.oracle.com/en/database/oracle/oracle-database/23/sqlrf/Data-Types.html`
`73`	`73`	`*`
`74`		`- * @psalm-var string[]`
	`74`	`+ * @var string[]`
`75`	`75`	`*/`
`76`		`- private array $typeMap = [`
	`76`	`+ private const TYPE_MAP = [`
`77`	`77`	`'char' => self::TYPE_CHAR,`
`78`	`78`	`'nchar' => self::TYPE_CHAR,`
`79`	`79`	`'varchar2' => self::TYPE_STRING,`
`@@ -664,7 +664,7 @@ private function extractColumnType(ColumnSchemaInterface $column): string`
`664`	`664`	`return self::TYPE_STRING;`
`665`	`665`	`}`
`666`	`666`
`667`		`- return $this->typeMap[$dbType] ?? self::TYPE_STRING;`
	`667`	`+ return self::TYPE_MAP[$dbType] ?? self::TYPE_STRING;`
`668`	`668`	`}`
`669`	`669`
`670`	`670`	`/**`