Fix float type in AbstractCommand::getRawSql() (#828)

Tigrov · web-flow · commit c68e2c82da50 · 2024-05-01T09:40:13.000+07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 - Enh #806: Non-unique placeholder names inside `Expression::$params` will be replaced with unique names (@Tigrov)
 - Enh #806: Build `Expression` instances inside `Expression::$params` when build a query using `QueryBuilder` (@Tigrov)
 - Enh #766: Allow `ColumnInterface` as column type. (@Tigrov)
+- Bug #828: Fix `float` type when use `AbstractCommand::getRawSql()` method (@Tigrov)
 
 ## 1.3.0 March 21, 2024
 
diff --git a/src/Command/AbstractCommand.php b/src/Command/AbstractCommand.php
@@ -12,9 +12,11 @@
 use Yiisoft\Db\Query\QueryInterface;
 use Yiisoft\Db\QueryBuilder\QueryBuilderInterface;
 use Yiisoft\Db\Schema\Builder\ColumnInterface;
+use Yiisoft\Db\Schema\SchemaInterface;
 
 use function explode;
 use function get_resource_type;
+use function gettype;
 use function is_array;
 use function is_int;
 use function is_resource;
@@ -351,11 +353,13 @@ public function getRawSql(): string
             $value = $param->getValue();
 
             $params[$name] = match ($param->getType()) {
-                DataType::INTEGER => (string)(int)$value,
-                DataType::STRING, DataType::LOB => match (true) {
-                    $value instanceof Expression => (string)$value,
-                    is_resource($value) => $name,
-                    default => $quoter->quoteValue((string)$value),
+                DataType::INTEGER => (string) (int) $value,
+                DataType::STRING, DataType::LOB => match (gettype($value)) {
+                    SchemaInterface::PHP_TYPE_RESOURCE => $name,
+                    SchemaInterface::PHP_TYPE_DOUBLE => (string) $value,
+                    default => $value instanceof Expression
+                        ? (string) $value
+                        : $quoter->quoteValue((string) $value),
                 },
                 DataType::BOOLEAN => $value ? 'TRUE' : 'FALSE',
                 DataType::NULL => 'NULL',
diff --git a/tests/Provider/CommandProvider.php b/tests/Provider/CommandProvider.php
@@ -741,6 +741,18 @@ public static function rawSql(): array
                     static::$driverName,
                 ),
             ],
+            [
+                <<<SQL
+                SELECT * FROM [[product]] WHERE [[price]] = :price
+                SQL,
+                ['price' => 123.45],
+                DbHelper::replaceQuotes(
+                    <<<SQL
+                    SELECT * FROM [[product]] WHERE [[price]] = 123.45
+                    SQL,
+                    static::$driverName,
+                ),
+            ],
         ];
     }
 
