Fix 6: Remove unnecessary methods, fix phpdoc. (#389)

terabytesoftw · web-flow · commit 9a45df6c9e22 · 2022-11-20T14:28:05.000-03:00
* Remove unnecessary methods, fix phpdoc. (#389)
diff --git a/src/Connection/ConnectionInterface.php b/src/Connection/ConnectionInterface.php
@@ -185,6 +185,9 @@ public function getTransaction(): TransactionInterface|null;
      */
     public function isActive(): bool;
 
+    /**
+     * @return bool whether this DBMS supports [savepoint](http://en.wikipedia.org/wiki/Savepoint).
+     */
     public function isSavepointEnabled(): bool;
 
     /**
diff --git a/src/Driver/PDO/TransactionPDO.php b/src/Driver/PDO/TransactionPDO.php
@@ -73,9 +73,7 @@ public function begin(string $isolationLevel = null): void
             return;
         }
 
-        $schema = $this->db->getSchema();
-
-        if ($schema->supportsSavepoint()) {
+        if ($this->db->isSavepointEnabled()) {
             $this->logger?->log(LogLevel::DEBUG, 'Set savepoint ' . $this->level . ' ' . __METHOD__);
 
             $this->createSavepoint('LEVEL' . $this->level);
@@ -108,9 +106,7 @@ public function commit(): void
             return;
         }
 
-        $schema = $this->db->getSchema();
-
-        if ($schema->supportsSavepoint()) {
+        if ($this->db->isSavepointEnabled()) {
             $this->logger?->log(LogLevel::DEBUG, 'Release savepoint ' . $this->level . ' ' . __METHOD__);
             $this->releaseSavepoint('LEVEL' . $this->level);
         } else {
@@ -160,8 +156,7 @@ public function rollBack(): void
             return;
         }
 
-        $schema = $this->db->getSchema();
-        if ($schema->supportsSavepoint()) {
+        if ($this->db->isSavepointEnabled()) {
             $this->logger?->log(LogLevel::DEBUG, 'Roll back to savepoint ' . $this->level . ' ' . __METHOD__);
             $this->rollBackSavepoint('LEVEL' . $this->level);
         } else {
diff --git a/src/Schema/SchemaInterface.php b/src/Schema/SchemaInterface.php
@@ -17,11 +17,6 @@ interface SchemaInterface extends ConstraintSchemaInterface
      */
     public function getDefaultSchema(): string|null;
 
-    /**
-     * @inheritDoc
-     */
-    public function getLastInsertID(string $sequenceName = null): string;
-
     /**
      * Determines the PDO type for the given PHP data value.
      *
@@ -165,11 +160,6 @@ public function refreshTableSchema(string $name): void;
      */
     public function schemaCacheEnable(bool $value): void;
 
-    /**
-     * @return bool whether this DBMS supports [savepoint](http://en.wikipedia.org/wiki/Savepoint).
-     */
-    public function supportsSavepoint(): bool;
-
     /**
      * Returns all view names in the database.
      *
