Fix #19: Run tests with PHP 8.2 in CI (#20)

s1lver · web-flow · commit 13086abc5e77 · 2023-07-12T18:17:03.000+03:00
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -29,7 +29,11 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: [ '8.0', '8.1' ]
+        php:
+          - '8.0'
+          - '8.1'
+          - '8.2'
+
     steps:
       - name: Checkout
         uses: actions/checkout@v2
diff --git a/.github/workflows/mutation.yml b/.github/workflows/mutation.yml
@@ -34,6 +34,7 @@ jobs:
         php:
           - '8.0'
           - '8.1'
+          - '8.2'
 
     steps:
       - name: Checkout
diff --git a/.github/workflows/static.yml b/.github/workflows/static.yml
@@ -36,6 +36,7 @@ jobs:
         php:
           - 8.0
           - 8.1
+          - 8.2
 
     steps:
       - name: Checkout
diff --git a/src/RedisCache.php b/src/RedisCache.php
@@ -245,8 +245,6 @@ private function iterableToArray(iterable $iterable): array
     }
 
     /**
-     * @param string $key
-     *
      * @throws InvalidArgumentException
      */
     private function validateKey(string $key): void
@@ -273,8 +271,6 @@ private function validateKeys(array $keys): void
     }
 
     /**
-     * @param int|null $ttl
-     *
      * @return bool
      */
     private function isExpiredTtl(?int $ttl): bool
@@ -283,8 +279,6 @@ private function isExpiredTtl(?int $ttl): bool
     }
 
     /**
-     * @param int|null $ttl
-     *
      * @return bool
      */
     private function isInfinityTtl(?int $ttl): bool
diff --git a/tests/RedisClusterCacheTest.php b/tests/RedisClusterCacheTest.php
@@ -85,9 +85,6 @@ public function dataProvider(): array
     /**
      * @dataProvider dataProvider
      *
-     * @param string $key
-     * @param mixed $value
-     *
      * @throws InvalidArgumentException
      */
     public function testSet(string $key, mixed $value): void
@@ -100,9 +97,6 @@ public function testSet(string $key, mixed $value): void
     /**
      * @dataProvider dataProvider
      *
-     * @param string $key
-     * @param mixed $value
-     *
      * @throws InvalidArgumentException
      */
     public function testSetWithTtl(string $key, mixed $value): void
@@ -252,12 +246,9 @@ public function dataProviderNormalizeTtl(): array
     /**
      * @dataProvider dataProviderNormalizeTtl
      *
-     * @param mixed $ttl
-     * @param mixed $expectedResult
-     *
      * @throws ReflectionException
      */
-    public function testNormalizeTtl($ttl, $expectedResult): void
+    public function testNormalizeTtl(mixed $ttl, mixed $expectedResult): void
     {
         $reflection = new ReflectionObject($this->cache);
         $method = $reflection->getMethod('normalizeTtl');
@@ -281,54 +272,44 @@ public function invalidKeyProvider(): array
 
     /**
      * @dataProvider invalidKeyProvider
-     *
-     * @param mixed $key
      */
-    public function testGetThrowExceptionForInvalidKey($key): void
+    public function testGetThrowExceptionForInvalidKey(mixed $key): void
     {
         $this->expectException(InvalidArgumentException::class);
         $this->cache->get($key);
     }
 
     /**
      * @dataProvider invalidKeyProvider
-     *
-     * @param mixed $key
      */
-    public function testHasThrowExceptionForInvalidKey($key): void
+    public function testHasThrowExceptionForInvalidKey(mixed $key): void
     {
         $this->expectException(InvalidArgumentException::class);
         $this->cache->has($key);
     }
 
     /**
      * @dataProvider invalidKeyProvider
-     *
-     * @param mixed $key
      */
-    public function testDeleteThrowExceptionForInvalidKey($key): void
+    public function testDeleteThrowExceptionForInvalidKey(mixed $key): void
     {
         $this->expectException(InvalidArgumentException::class);
         $this->cache->delete($key);
     }
 
     /**
      * @dataProvider invalidKeyProvider
-     *
-     * @param mixed $key
      */
-    public function testGetMultipleThrowExceptionForInvalidKeys($key): void
+    public function testGetMultipleThrowExceptionForInvalidKeys(mixed $key): void
     {
         $this->expectException(InvalidArgumentException::class);
         $this->cache->getMultiple([$key]);
     }
 
     /**
      * @dataProvider invalidKeyProvider
-     *
-     * @param mixed $key
      */
-    public function testDeleteMultipleThrowExceptionForInvalidKeys($key): void
+    public function testDeleteMultipleThrowExceptionForInvalidKeys(mixed $key): void
     {
         $this->expectException(InvalidArgumentException::class);
         $this->cache->deleteMultiple([$key]);
@@ -353,8 +334,6 @@ public function testSetMultipleThrowExceptionForEmptyArray(): void
     }
 
     /**
-     * @param array $values
-     *
      * @return array
      */
     private function prepareKeysOfValues(array $values): array
@@ -377,10 +356,6 @@ private function getDataProviderData(): array
         return $data;
     }
 
-    /**
-     * @param mixed $expected
-     * @param mixed $actual
-     */
     private function assertSameExceptObject(mixed $expected, mixed $actual): void
     {
         // Assert for all types.
@@ -443,9 +418,6 @@ public function getIterator(): ArrayIterator
     /**
      * @dataProvider iterableProvider
      *
-     * @param array $array
-     * @param iterable $iterable
-     *
      * @throws InvalidArgumentException
      */
     public function testValuesAsIterable(array $array, iterable $iterable): void
diff --git a/tests/docker/docker-compose.yml b/tests/docker/docker-compose.yml
@@ -10,7 +10,7 @@ services:
       args:
         PHP_VERSION: ${PHP_VERSION:-8.1}
     volumes:
-      - ../runtime/.composer80:/root/.composer
+      - ../runtime/.composer:/root/.composer
       - ../..:/var/www
     networks: &network
       - cache-redis-network

-Original file line number
+Diff line change
         php:
           - '8.0'
           - '8.1'
 +          - '8.2'
     steps:
       - name: Checkout