Merge pull request #249 from yiisoft/add-rector

xepozz · web-flow · commit 531bb26b8d25 · 2022-10-29T00:15:20.000+03:00
Add rector [batch]
diff --git a/.github/workflows/rector.yml b/.github/workflows/rector.yml
@@ -0,0 +1,21 @@
+on:
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+      - 'infection.json.dist'
+      - 'psalm.xml'
+
+name: rector
+
+jobs:
+  rector:
+    uses: yiisoft/actions/.github/workflows/rector.yml@master
+    with:
+      os: >-
+        ['ubuntu-latest']
+      php: >-
+        ['8.0']
diff --git a/composer.json b/composer.json
@@ -63,6 +63,7 @@
         "codeception/module-cli": "^2.0",
         "codeception/module-phpbrowser": "^3.0",
         "phpunit/phpunit": "^9.5",
+        "rector/rector": "^0.14.3",
         "roave/infection-static-analysis-plugin": "^1.16",
         "roave/security-advisories": "dev-master",
         "spatie/phpunit-watcher": "^1.23",
diff --git a/rector.php b/rector.php
@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
+use Rector\Config\RectorConfig;
+use Rector\Set\ValueObject\LevelSetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->paths([
+        __DIR__ . '/src',
+        __DIR__ . '/tests',
+    ]);
+
+    // register a single rule
+    $rectorConfig->rule(InlineConstructorDefaultToPropertyRector::class);
+
+    // define sets of rules
+    $rectorConfig->sets([
+        LevelSetList::UP_TO_PHP_80,
+    ]);
+};
diff --git a/src/ViewInjection/CommonViewInjection.php b/src/ViewInjection/CommonViewInjection.php
@@ -9,12 +9,8 @@
 
 final class CommonViewInjection implements CommonParametersInjectionInterface
 {
-    private ApplicationParameters $applicationParameters;
-
-    public function __construct(
-        ApplicationParameters $applicationParameters
-    ) {
-        $this->applicationParameters = $applicationParameters;
+    public function __construct(private ApplicationParameters $applicationParameters)
+    {
     }
 
     public function getCommonParameters(): array

Original file line number	Diff line number	Diff line change
`@@ -9,12 +9,8 @@`
`9`	`9`
`10`	`10`	`final class CommonViewInjection implements CommonParametersInjectionInterface`
`11`	`11`	`{`
`12`		`- private ApplicationParameters $applicationParameters;`
`13`		`-`
`14`		`- public function __construct(`
`15`		`- ApplicationParameters $applicationParameters`
`16`		`- ) {`
`17`		`- $this->applicationParameters = $applicationParameters;`
	`12`	`+ public function __construct(private ApplicationParameters $applicationParameters)`
	`13`	`+ {`
`18`	`14`	`}`
`19`	`15`
`20`	`16`	`public function getCommonParameters(): array`