Merged
Conversation
defining `fail = error` for SIO, with a `HasCallStack` so that when we fail to match in a do block we immediately alert the caller and have a callstack. this is fine to do in testing since this can be a form of test in and of itself example: ``` test = do [oneElem] <- getListOfThings -- ^ if this doesn't return exactly one element, we'll fail out doWithOneElem oneElem ```
jezen
approved these changes
Jun 6, 2025
Member
jezen
left a comment
There was a problem hiding this comment.
Looks sensible. Thanks for the clear commit message!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddocks for new, public APIsAfter submitting your PR: