Skip to content

Add bySelectorLabelContain to support testing inputs with the same label#1781

Merged
snoyberg merged 7 commits intoyesodweb:masterfrom
eahlberg:add-by-selector-label-contain
Sep 22, 2022
Merged

Add bySelectorLabelContain to support testing inputs with the same label#1781
snoyberg merged 7 commits intoyesodweb:masterfrom
eahlberg:add-by-selector-label-contain

Conversation

@eahlberg
Copy link
Copy Markdown
Contributor

@eahlberg eahlberg commented Sep 21, 2022 •
edited
Loading

Fixes #1770

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@eahlberg eahlberg mentioned this pull request Sep 21, 2022
Closed
@eahlberg
Copy link
Copy Markdown
Contributor Author

eahlberg commented Sep 21, 2022 •
edited
Loading

  1. The first two commits implement the functionality whereas the third is a refactoring to avoid duplication. The commits are structured so they can be reviewed in order.
  2. From my understanding this change warrants a minor version bump (1.6.14 -> 1.6.15) since this is a new public API.
  3. This only adds bySelectorLabelContain, but similar to byLabelContain, there could be a case made for adding bySelectorLabelPrefix, bySelectorLabelSuffix, etc. right away.

@eahlberg eahlberg force-pushed the add-by-selector-label-contain branch from 7851648 to bca7557 Compare September 21, 2022 11:51
snoyberg
snoyberg approved these changes Sep 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@snoyberg snoyberg merged commit f729d9b into yesodweb:master Sep 22, 2022
@eahlberg
Copy link
Copy Markdown
Contributor Author

eahlberg commented Sep 22, 2022

Cool, thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

yesod-test: testing radio buttons with the same label

2 participants

@eahlberg @snoyberg