Fix quote ' not matching in htmlContain* functions#1768
Merged
snoyberg merged 3 commits intoyesodweb:masterfrom May 11, 2022
Merged
Fix quote ' not matching in htmlContain* functions#1768snoyberg merged 3 commits intoyesodweb:masterfrom
snoyberg merged 3 commits intoyesodweb:masterfrom
Conversation
This sometimes occured in our code base when generating names with the fakedata package, someone named o'conner randomly fails a particular test. Also add tests for the other matching function and fixed them. Furthermore, I snuck in logging of the matches as well.
snoyberg
approved these changes
May 11, 2022
Member
snoyberg
left a comment
There was a problem hiding this comment.
Test case demonstrates the problem nicely!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sometimes occurred in our code base when generating
names with the fakedata package, someone named o'conner
randomly fails a particular test.
Also add tests for the other matching function and fixed them.
Furthermore, I added logging of the matches as well.
Before submitting your PR, check that you've:
@sincedeclarations to the Haddocks for new, public APIsAfter submitting your PR: