Skip to content

Fix up missing HasCallStack#1710

Merged
snoyberg merged 4 commits intomasterfrom
pb/has-callstack
Dec 2, 2020
Merged

Fix up missing HasCallStack#1710
snoyberg merged 4 commits intomasterfrom
pb/has-callstack

Conversation

@pbrisbin
Copy link
Copy Markdown
Member

@pbrisbin pbrisbin commented Dec 1, 2020

Two chanages:

  • 24acd4e Add missing HasCallStack

    Even though functions that use this one all have HasCallStack, the fact
    that this function itself doesn't means that test failures are reported as
    from this line anyway:

    Failures:
    
      ./Yesod/Test.hs:1571:28:
      1) ...
    

    This should correct that.

  • 07d7609 Add missing HasCallStacks

    As far as I could tell, all of these functions call failure, or call things
    that call failure.


Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Even though functions that use this one all have HasCallStack, the fact
that this function itself doesn't means that all errors are reported as
from this line anyway:

    Failures:

      ./Yesod/Test.hs:1571:28:
      1) ...

This should correct that.
As far as I could tell, all of these functions call failure, or call
things that call failure.
Copy link
Copy Markdown
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit c6c2cd2 into master Dec 2, 2020
@snoyberg snoyberg deleted the pb/has-callstack branch December 2, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants