Conversation
Even though functions that use this one all have HasCallStack, the fact
that this function itself doesn't means that all errors are reported as
from this line anyway:
Failures:
./Yesod/Test.hs:1571:28:
1) ...
This should correct that.
As far as I could tell, all of these functions call failure, or call things that call failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two chanages:
24acd4e Add missing
HasCallStackEven though functions that use this one all have
HasCallStack, the factthat this function itself doesn't means that test failures are reported as
from this line anyway:
This should correct that.
07d7609 Add missing
HasCallStacksAs far as I could tell, all of these functions call
failure, or call thingsthat call
failure.Before submitting your PR, check that you've:
Bumped the version number
Documented new APIs with Haddock markup
N/A
Added
@sincedeclarations to the Haddocks for new, public APIsN/A
After submitting your PR: