[yesod-test] Add utility functions to modify cookies#1570
Merged
MaxGabriel merged 1 commit intomasterfrom Jan 15, 2019
Merged
Conversation
af5790f to
bedec86
Compare
snoyberg
approved these changes
Jan 15, 2019
Member
snoyberg
left a comment
There was a problem hiding this comment.
LGTM, I have no concerns with the naming you've chosen, and agree that the name collisions we already have are unfortunate. Should we merge and release?
Member
Author
|
Thanks @snoyberg; merged and uploaded! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, maybe I missed something obvious, but it seems like the functions to modify the current
YesodExampleDataare private, and one couldn't modify cookies. I think testing modifying the cookies seems like reasonable functionality to have, because users and browsers can obviously change them.This is kind of a problem with all of yesod-test having generic names like
get, but names likesetCookieconflict with ones in Yesod itself. Thoughts on this? I prefixed them withtestbut maybe prefixing withyis better?(In our application we've just imported yesod-test qualified, so we don't have this issue)
Before submitting your PR, check that you've:
@sincedeclarations to the Haddocks for new, public APIsAfter submitting your PR: