Skip to content

[yesod-test] Add utility functions to modify cookies#1570

Merged
MaxGabriel merged 1 commit intomasterfrom
cookieHelpers
Jan 15, 2019
Merged

[yesod-test] Add utility functions to modify cookies#1570
MaxGabriel merged 1 commit intomasterfrom
cookieHelpers

Conversation

@MaxGabriel
Copy link
Copy Markdown
Member

@MaxGabriel MaxGabriel commented Jan 15, 2019

So, maybe I missed something obvious, but it seems like the functions to modify the current YesodExampleData are private, and one couldn't modify cookies. I think testing modifying the cookies seems like reasonable functionality to have, because users and browsers can obviously change them.

This is kind of a problem with all of yesod-test having generic names like get, but names like setCookie conflict with ones in Yesod itself. Thoughts on this? I prefixed them with test but maybe prefixing with y is better?

(In our application we've just imported yesod-test qualified, so we don't have this issue)

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Copy link
Copy Markdown
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have no concerns with the naming you've chosen, and agree that the name collisions we already have are unfortunate. Should we merge and release?

@MaxGabriel MaxGabriel merged commit 673db5f into master Jan 15, 2019
@MaxGabriel
Copy link
Copy Markdown
Member Author

Thanks @snoyberg; merged and uploaded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants