bodyEquals prints actual body.#1525
Merged
snoyberg merged 1 commit intoyesodweb:masterfrom Jun 14, 2018
Merged
Conversation
Member
Author
|
Hoping to address #1495. |
snoyberg
reviewed
Jun 14, 2018
yesod-test/Yesod/Test.hs
Outdated
| (simpleBody res) == encodeUtf8 (TL.pack text) | ||
| bodyEquals text = withResponse $ \ res -> do | ||
| let actual = simpleBody res | ||
| msg = concat ["Expected body to equal ", text, ". Actual is: ", BSL8.unpack actual] |
Member
There was a problem hiding this comment.
Would it make sense for display purposes to put text and actual on their own lines? Also, I think it would be better to use UTF8 decoding (maybe via decodeUtf8With lenientDecode) instead of Char8.
Member
Author
There was a problem hiding this comment.
Changes made. Let me know what you think.
snoyberg
approved these changes
Jun 14, 2018
Member
snoyberg
left a comment
There was a problem hiding this comment.
LGTM, let's merge when Travis goes green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
After submitting your PR: