Skip to content

Bylabel contain#1482

Merged
MaxGabriel merged 8 commits intoyesodweb:masterfrom
pythonissam:bylabel-contain
Feb 11, 2018
Merged

Bylabel contain#1482
MaxGabriel merged 8 commits intoyesodweb:masterfrom
pythonissam:bylabel-contain

Conversation

@pythonissam
Copy link
Copy Markdown
Contributor

@pythonissam pythonissam commented Feb 3, 2018

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

ref: #1480

@MaxGabriel
Copy link
Copy Markdown
Member

Can you also update the deprecation warnings for the old byLabel to point to byLabelContains for an exact replacement?

@MaxGabriel
Copy link
Copy Markdown
Member

@pythonissam LGTM. Yesod-test 1.6.1 was released after you started this PR though, can you bump the version you're using in your Cabal file, @since docs, and Changelog?

@pythonissam
Copy link
Copy Markdown
Contributor Author

Is this alright? Besides, travis seems to fail. Is this okay?

@MaxGabriel
Copy link
Copy Markdown
Member

@pythonissam Yep that looks good. The Appveyor tests were failing because of a merge conflict with master. It looks like all but one of the Travis tests passed (and the failure was unrelated to your changes). I fixed two merge conflicts in your PR, and I'll let CI run on that before merging.

@pythonissam
Copy link
Copy Markdown
Contributor Author

I see. Thank you.

@MaxGabriel MaxGabriel merged commit f2b651b into yesodweb:master Feb 11, 2018
@MaxGabriel
Copy link
Copy Markdown
Member

Merged, thanks for your work here @pythonissam!

@snoyberg Can you add me as a maintainer of yesod-test on hackage? I couldn't release this

@snoyberg
Copy link
Copy Markdown
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants