Bylabel contain#1482
Conversation
|
Can you also update the deprecation warnings for the old byLabel to point to byLabelContains for an exact replacement? |
|
@pythonissam LGTM. Yesod-test 1.6.1 was released after you started this PR though, can you bump the version you're using in your Cabal file, |
|
Is this alright? Besides, travis seems to fail. Is this okay? |
|
@pythonissam Yep that looks good. The Appveyor tests were failing because of a merge conflict with master. It looks like all but one of the Travis tests passed (and the failure was unrelated to your changes). I fixed two merge conflicts in your PR, and I'll let CI run on that before merging. |
|
I see. Thank you. |
|
Merged, thanks for your work here @pythonissam! @snoyberg Can you add me as a maintainer of yesod-test on hackage? I couldn't release this |
|
Done! |
Before submitting your PR, check that you've:
@sincedeclarations to the Haddocks for new, public APIsAfter submitting your PR:
ref: #1480